Paths

Table of Contentst

Differential D20731

Expose "commits.add|set|remove" on "maniphest.edit" API calls
ClosedPublic
Actions

Authored by epriestley on Aug 22 2019, 8:31 PM.

Tags

None

Referenced Files

	F22773464: D20731.diff
	Mon, Oct 5, 9:45 PM

	Unknown Object (File)
	Tue, Sep 15, 2:52 PM

	Unknown Object (File)
	Aug 11 2026, 5:37 PM

	Unknown Object (File)
	Apr 6 2026, 8:47 AM

	Unknown Object (File)
	Apr 3 2026, 1:45 PM

	Unknown Object (File)
	Apr 3 2026, 1:44 PM

	Unknown Object (File)
	Feb 4 2026, 3:23 AM

	Unknown Object (File)
	Nov 5 2025, 5:51 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPecbc82da33c5: Expose "commits.add|set|remove" on "maniphest.edit" API calls

Summary

See PHI1396. Ideally this would be some kind of general-purpose tie-in to object relationships, but see D18456 for precedent.

Test Plan

Used maniphest.edit to edit associated commits for a task.

Diff Detail

Repository

rP Phabricator

Branch

tasks1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23283
Build 31992: Run Core Tests
Build 31991: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 22 2019, 8:31 PM

Harbormaster completed remote builds in B23283: Diff 49425.Aug 22 2019, 8:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2019, 8:33 PM

epriestley requested review of this revision.

Closed by commit rPecbc82da33c5: Expose "commits.add|set|remove" on "maniphest.edit" API calls (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPecbc82da33c5: Expose "commits.add|set|remove" on "maniphest.edit" API calls.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestEditEngine.php

21 lines

Diff 49425

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Expose "commits.add|set|remove" on "maniphest.edit" API callsClosedPublicActions