Page MenuHomePhabricator

Respect "disabled" custom field status granted by "subtype" configuration in form validation
ClosedPublic

Authored by epriestley on Aug 22 2019, 1:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 9:48 AM
Unknown Object (File)
Sat, Dec 7, 2:20 PM
Unknown Object (File)
Sat, Dec 7, 2:43 AM
Unknown Object (File)
Nov 26 2024, 8:09 PM
Unknown Object (File)
Nov 22 2024, 5:21 PM
Unknown Object (File)
Nov 18 2024, 2:14 AM
Unknown Object (File)
Nov 13 2024, 11:38 PM
Unknown Object (File)
Nov 9 2024, 8:15 PM
Subscribers
None

Details

Summary

Fixes T13384. Currently, the subtype "disabled" configuration is not respected when selecting fields for ROLE_EDIT.

The only meaningful caller for ROLE_EDIT is transaction validation, but transaction validation should respect fields being disabled by subtype configuration.

Test Plan
  • Added a "required" Maniphest custom field "F", then "disabled" it in a subtype "S".
  • Created a task of subtype "S".
    • Before: Form submission fails with error "F is required", even though the field is not actually visible on the form and can not be set.
    • After: Form submits cleanly and creates the task.

Diff Detail

Repository
rP Phabricator
Branch
dfield1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23274
Build 31978: Run Core Tests
Build 31977: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Aug 22 2019, 1:03 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.