Paths

Table of Contentst

Differential D20714

Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints
ClosedPublic
Actions

Authored by epriestley on Aug 15 2019, 7:02 PM.

Tags

None

Referenced Files

	F15402108: D20714.id49394.diff
	Mon, Mar 17, 8:40 PM

	F15334898: D20714.diff
	Sat, Mar 8, 1:12 PM

	Unknown Object (File)
	Mon, Mar 3, 3:34 PM

	Unknown Object (File)
	Feb 22 2025, 12:37 AM

	Unknown Object (File)
	Feb 16 2025, 5:14 PM

	Unknown Object (File)
	Feb 12 2025, 12:55 PM

	Unknown Object (File)
	Feb 9 2025, 7:59 AM

	Unknown Object (File)
	Feb 9 2025, 7:59 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging
Commits: rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret…

Summary

Fixes T13378. If we join Ferret tables and page, we can end up with an ambiguous id column here.

Explicitly refer to "project.x" in all cases that we're interacting with the project table.

Test Plan

Changed page size to 3.
Issued a Projects query for "~e", matching more than 3 results.
Clicked "Next Page".
- Before: ambiguous id column fatal.
- After: next page.

Diff Detail

Repository

Branch

ppage1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23254
Build 31944: Run Core Tests
Build 31943: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 15 2019, 7:02 PM

Harbormaster completed remote builds in B23254: Diff 49394.Aug 15 2019, 7:03 PM

epriestley requested review of this revision.Aug 15 2019, 7:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2019, 7:22 PM

Closed by commit rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret….

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

48 lines

Diff 49394

src/applications/project/query/PhabricatorProjectQuery.php

Loading...