Paths

Table of Contentst

Differential D20694

Modernize user and repository "delete" workflows and improve documentation
ClosedPublic
Actions

Authored by epriestley on Aug 2 2019, 4:23 PM.

Tags

None

Referenced Files

	F14093842: D20694.diff
	Mon, Nov 25, 1:02 PM

	Unknown Object (File)
	Wed, Nov 20, 8:22 PM

	Unknown Object (File)
	Sat, Nov 16, 10:54 PM

	Unknown Object (File)
	Sat, Nov 16, 12:35 PM

	Unknown Object (File)
	Tue, Nov 12, 6:44 AM

	Unknown Object (File)
	Sat, Nov 9, 1:09 PM

	Unknown Object (File)
	Fri, Nov 1, 4:00 AM

	Unknown Object (File)
	Oct 23 2024, 5:21 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T8830: `bin/remove destroy` is dangerous and leaves dangling edges
T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation
Commits: rP1fe631116771: Modernize user and repository "delete" workflows and improve documentation

Summary

Fixes T8830. Fixes T13364.

The inability to destroy objects from the web UI is intentional. Make this clear in the messaging, which is somewhat out of date and partly reflects an earlier era when things could be destroyed.
bin/remove destroy can't rewind time. Document expectations around the "put the cat back in the bag" use case.

Test Plan

Read documentation, clicked through both workflows.

Diff Detail

Repository

Branch

doc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23220
Build 31895: Run Core Tests
Build 31894: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 2 2019, 4:23 PM

Harbormaster completed remote builds in B23220: Diff 49355.Aug 2 2019, 4:25 PM

epriestley requested review of this revision.Aug 2 2019, 4:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 4:31 PM

Closed by commit rP1fe631116771: Modernize user and repository "delete" workflows and improve documentation (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1fe631116771: Modernize user and repository "delete" workflows and improve documentation.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

diffusion/

controller/

DiffusionRepositoryEditDeleteController.php

47 lines

management/

DiffusionRepositoryBasicsManagementPanel.php

2 lines

people/

controller/

PhabricatorPeopleDeleteController.php

73 lines

docs/

user/

field/

permanently_destroying_data.diviner

92 lines

userguide/

diffusion_managing.diviner

9 lines

view/

AphrontDialogView.php

35 lines

webroot/

rsrc/

css/

aphront/

dialog-view.css

5 lines

Diff 49355

resources/celerity/map.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php

Loading...

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

Loading...

src/applications/people/controller/PhabricatorPeopleDeleteController.php

Loading...

src/docs/user/field/permanently_destroying_data.diviner

Loading...

src/docs/user/userguide/diffusion_managing.diviner

Loading...

src/view/AphrontDialogView.php

Loading...

webroot/rsrc/css/aphront/dialog-view.css

Loading...