Page MenuHomePhabricator
Differential D20690

Support "date" custom fields in "*.edit" endpoints
ClosedPublic
Actions

Authored by epriestley on Jul 31 2019, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 4:47 PM
Unknown Object (File)
Sun, Feb 9, 7:56 AM
Unknown Object (File)
Sun, Feb 9, 7:56 AM
Unknown Object (File)
Sun, Feb 9, 7:56 AM
Unknown Object (File)
Sat, Jan 25, 5:23 AM
Unknown Object (File)
Sat, Jan 25, 5:23 AM
Unknown Object (File)
Sat, Jan 25, 5:23 AM
Unknown Object (File)
Tue, Jan 21, 9:52 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13355: Support editing "date" custom fields via Conduit
Commits
rP8e263a2f6482: Support "date" custom fields in "*.edit" endpoints
Summary

Fixes T13355. This didn't appear to be a ton of extra work, we just didn't get it for free in the original implementation in D14635.

Test Plan
  • Saw "date" custom fields appear in Conduit API documentation for "maniphest.edit".
  • Set custom "date" field to null and non-null values via the API.

Screen Shot 2019-07-31 at 12.47.33 PM.png (325×1 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
cfield2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23210
Build 31881: Run Core Tests
Build 31880: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 31 2019, 7:48 PM
Harbormaster completed remote builds in B23210: Diff 49345.Jul 31 2019, 7:50 PM
epriestley requested review of this revision.Jul 31 2019, 7:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2019, 8:10 PM
Closed by commit rP8e263a2f6482: Support "date" custom fields in "*.edit" endpoints (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8e263a2f6482: Support "date" custom fields in "*.edit" endpoints.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
parametertype/
16 lines
transactions/
editfield/
3 lines
infrastructure/
customfield/
standard/
10 lines

Diff 49345

View Options

src/applications/conduit/parametertype/ConduitEpochParameterType.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEpochEditField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

Loading...
Phabricator · Built by Phacility