Differential D20688

When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing
ClosedPublic
Actions

Authored by epriestley on Jul 31 2019, 6:40 PM.

Details

Reviewers: None
Maniphest Tasks: T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing
Commits: rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI…

Summary

Fixes T13353. If you:

Visit a blog post and save the URI.
Move the blog post to a different blog.
Revisit the old URI.

...we currently 404. We know what you're trying to do and should just redirect you to the new URI instead. We already do this if you visit a URI with a noncanonical slug.

Test Plan

Created post A.
Copied the live URI.
Moved it to a different blog.
Visited the saved URI from the earlier step.
Before: 404.
After: Redirect to the canonical URI.

Diff Detail

Repository

rP Phabricator

Branch

phameredir1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23205
Build 31874: Run Core Tests
Build 31873: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 31 2019, 6:40 PM

Harbormaster completed remote builds in B23205: Diff 49341.Jul 31 2019, 6:41 PM

epriestley requested review of this revision.Jul 31 2019, 6:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2019, 6:44 PM

Closed by commit rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI….

Krinkle awarded a token.Jul 31 2019, 6:58 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameLiveController.php

13 lines

Diff 49341

View Options

src/applications/phame/controller/PhameLiveController.php

When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ingClosedPublicActions