Differential D20554

Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()"
ClosedPublic
Actions

Authored by epriestley on May 23 2019, 11:36 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled

Commits

rPHU1422024de70d: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()"

Summary

Ref T13296. On macOS with PHP 7.3.x, PCRE can segfault during calls to "preg_match()" or during process shutdown.

Disabling "pcre.jit" appears to work around this issue. Some casual Googling suggests that the JIT does not dramatically improve performance (~10%?) and we aren't PCRE-bound anyway, so prefer "not crashing" over "questionable performance improvements" on all systems for now.

Test Plan

See T13296 for details.
Ran bin/phd start on macOS with PHP 7.3.1.
Before patch: daemons don't actually start.
After patch: daemons start.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 23 2019, 11:36 PM

Harbormaster completed remote builds in B22904: Diff 49031.May 23 2019, 11:36 PM

epriestley requested review of this revision.May 23 2019, 11:36 PM

amckinley accepted this revision.May 23 2019, 11:58 PM

This revision is now accepted and ready to land.May 23 2019, 11:58 PM

Closed by commit rPHU1422024de70d: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()" (authored by epriestley). · Explain WhyMay 24 2019, 1:39 AM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU1422024de70d: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".

epriestley mentioned this in rPHU1422024de70d: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".

Revision Contents
Changeset List

			Path	Packages
M			scripts/__init_script__.php (4 lines)

Diff 49033

scripts/__init_script__.php

Loading...