Page MenuHomePhabricator

Fix two straggling pagination issues in Drydock
ClosedPublic

Authored by epriestley on May 23 2019, 6:55 PM.
Tags
None
Referenced Files
F19936958: D20553.id49028.diff
Sun, Apr 12, 5:43 PM
F19926128: D20553.id49028.diff
Tue, Apr 7, 3:26 PM
F19919564: D20553.diff
Sun, Apr 5, 4:20 AM
F19650192: D20553.diff
Feb 6 2026, 9:07 AM
F19071505: D20553.id.diff
Nov 30 2025, 7:46 PM
F19059795: D20553.diff
Nov 29 2025, 6:50 AM
F19053075: D20553.diff
Nov 28 2025, 7:12 AM
F18837948: D20553.id49028.diff
Oct 27 2025, 8:31 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13289. See https://discourse.phabricator-community.org/t/fatal-error-in-pagination-in-drydock-resources-host-logs-all-logs/2735.

bin/drydock lease and the web UI for reviewing all object logs when there is more than one page of logs didn't get fully updated to the new cursors.

  • Use a cursor pager in bin/drydock lease.
  • Implement withIDs() in LeaseQuery so the default paging works properly.
Test Plan
  • Ran bin/drydock lease, got a lease with log output along the way.
  • Set page size to 2, viewed host logs with multiple pages, paged to page 2.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable