Page MenuHomePhabricator

Fix two straggling pagination issues in Drydock
ClosedPublic

Authored by epriestley on May 23 2019, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 11:16 AM
Unknown Object (File)
Fri, Mar 1, 5:29 AM
Unknown Object (File)
Feb 21 2024, 1:49 PM
Unknown Object (File)
Feb 20 2024, 1:23 AM
Unknown Object (File)
Feb 3 2024, 10:36 PM
Unknown Object (File)
Feb 3 2024, 10:36 PM
Unknown Object (File)
Feb 3 2024, 10:36 PM
Unknown Object (File)
Jan 25 2024, 12:58 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13289. See https://discourse.phabricator-community.org/t/fatal-error-in-pagination-in-drydock-resources-host-logs-all-logs/2735.

bin/drydock lease and the web UI for reviewing all object logs when there is more than one page of logs didn't get fully updated to the new cursors.

  • Use a cursor pager in bin/drydock lease.
  • Implement withIDs() in LeaseQuery so the default paging works properly.
Test Plan
  • Ran bin/drydock lease, got a lease with log output along the way.
  • Set page size to 2, viewed host logs with multiple pages, paged to page 2.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable