Page MenuHomePhabricator

Fix two straggling pagination issues in Drydock
ClosedPublic

Authored by epriestley on Thu, May 23, 6:55 PM.

Details

Summary

Ref T13289. See https://discourse.phabricator-community.org/t/fatal-error-in-pagination-in-drydock-resources-host-logs-all-logs/2735.

bin/drydock lease and the web UI for reviewing all object logs when there is more than one page of logs didn't get fully updated to the new cursors.

  • Use a cursor pager in bin/drydock lease.
  • Implement withIDs() in LeaseQuery so the default paging works properly.
Test Plan
  • Ran bin/drydock lease, got a lease with log output along the way.
  • Set page size to 2, viewed host logs with multiple pages, paged to page 2.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 23, 6:55 PM
Owners added a subscriber: Restricted Owners Package.Thu, May 23, 6:55 PM
epriestley requested review of this revision.Thu, May 23, 6:56 PM
amckinley accepted this revision.Thu, May 23, 8:10 PM
This revision is now accepted and ready to land.Thu, May 23, 8:10 PM