Page MenuHomePhabricator

Fix two straggling pagination issues in Drydock
ClosedPublic

Authored by epriestley on May 23 2019, 6:55 PM.
Tags
None
Referenced Files
F18837948: D20553.id49028.diff
Oct 27 2025, 8:31 AM
F18835737: D20553.id.diff
Oct 26 2025, 6:29 PM
F18830475: D20553.diff
Oct 25 2025, 6:57 AM
F18745191: D20553.diff
Oct 3 2025, 5:39 AM
F18691059: D20553.diff
Sep 26 2025, 8:40 PM
F18570272: D20553.id49034.diff
Sep 10 2025, 3:19 AM
F18570271: D20553.id49028.diff
Sep 10 2025, 3:19 AM
F18566978: D20553.id.diff
Sep 9 2025, 3:26 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13289. See https://discourse.phabricator-community.org/t/fatal-error-in-pagination-in-drydock-resources-host-logs-all-logs/2735.

bin/drydock lease and the web UI for reviewing all object logs when there is more than one page of logs didn't get fully updated to the new cursors.

  • Use a cursor pager in bin/drydock lease.
  • Implement withIDs() in LeaseQuery so the default paging works properly.
Test Plan
  • Ran bin/drydock lease, got a lease with log output along the way.
  • Set page size to 2, viewed host logs with multiple pages, paged to page 2.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable