Page MenuHomePhabricator

Fix two straggling pagination issues in Drydock
ClosedPublic

Authored by epriestley on May 23 2019, 6:55 PM.
Tags
None
Referenced Files
F15580119: D20553.id.diff
Wed, May 7, 3:38 AM
F15546196: D20553.id49028.diff
Sat, Apr 26, 2:23 PM
F15477439: D20553.id49028.diff
Apr 7 2025, 2:42 PM
F15463149: D20553.id.diff
Apr 1 2025, 8:44 PM
F15456552: D20553.diff
Mar 30 2025, 10:29 AM
F15434433: D20553.id49034.diff
Mar 25 2025, 3:39 AM
F15432517: D20553.diff
Mar 24 2025, 6:26 PM
F15424615: D20553.id49028.diff
Mar 22 2025, 11:19 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13289. See https://discourse.phabricator-community.org/t/fatal-error-in-pagination-in-drydock-resources-host-logs-all-logs/2735.

bin/drydock lease and the web UI for reviewing all object logs when there is more than one page of logs didn't get fully updated to the new cursors.

  • Use a cursor pager in bin/drydock lease.
  • Implement withIDs() in LeaseQuery so the default paging works properly.
Test Plan
  • Ran bin/drydock lease, got a lease with log output along the way.
  • Set page size to 2, viewed host logs with multiple pages, paged to page 2.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable