Page MenuHomePhabricator

Deactivate the remarkup autosuggest once text can't match "[[" or "((" rules
ClosedPublic

Authored by epriestley on Apr 1 2019, 9:18 PM.
Tags
None
Referenced Files
F13052044: D20365.id48590.diff
Fri, Apr 19, 6:36 AM
Unknown Object (File)
Fri, Apr 19, 5:19 AM
Unknown Object (File)
Tue, Apr 16, 4:29 PM
Unknown Object (File)
Thu, Apr 4, 5:34 AM
Unknown Object (File)
Thu, Mar 28, 4:24 PM
Unknown Object (File)
Mar 10 2024, 12:01 PM
Unknown Object (File)
Feb 9 2024, 12:19 AM
Unknown Object (File)
Dec 22 2023, 11:41 AM
Subscribers
None

Details

Summary

See PHI1185, which reports a performance issue with "(" in remarkup in certain contexts.

I can't reproduce the performance issue, but I can reproduce the autosuggester incorrectly remaining active and swallowing return characters.

When the user types ( or [, we wait for a prefix for the (( (Phurl) or [[ (Phriction) rules. We currently continue looking for that prefix until a character is entered that explicitly interrupts the search.

For example, typing (xxx<return> does not insert a return character, because we're stuck on matching the prefix.

Instead, as soon as the user has entered text that we know won't ever match the prefix, deactivate the autocomplete. We can slightly cheat through this by just looking for at least one character of text, since all prefixes are exactly one character long. If we eventually have some kind of ~~@(xyz) rule we might need to add a more complicated piece of rejection logic.

Test Plan

Typed (xxx<return>, got a return. Used (( and [[ autosuggest rules normally. Used JX.log() to sanity check that nothing too crazy seems to be happening.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable