Page MenuHomePhabricator
Differential D20341

Fix a straggling issue with cursor changes impacting Conpherence thread indexing
ClosedPublic
Actions

Authored by epriestley on Mar 28 2019, 11:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:57 AM
Unknown Object (File)
Wed, Apr 24, 12:52 PM
Unknown Object (File)
Sat, Apr 20, 4:42 PM
Unknown Object (File)
Fri, Apr 19, 8:27 AM
Unknown Object (File)
Mon, Apr 1, 10:50 PM
Unknown Object (File)
Mon, Apr 1, 10:50 PM
Unknown Object (File)
Mon, Apr 1, 5:33 PM
Unknown Object (File)
Sat, Mar 30, 3:34 AM
View All 78 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13266: Upgrading: Minor Changes to Query Paging / Cursors
Commits
rPf1a7eb66da36: Fix a straggling issue with cursor changes impacting Conpherence thread indexing
Summary

Ref T13266. Caught one more of these "directly setting afterID" issues in the logs.

Test Plan

Ran bin/search index --type ConpherenceThread before and after changes. Before: fatal about a direct call. After: clean index rebuild.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 28 2019, 11:16 PM
Harbormaster completed remote builds in B22419: Diff 48548.Mar 28 2019, 11:18 PM
epriestley requested review of this revision.Mar 28 2019, 11:18 PM
epriestley retitled this revision from Fix a straggling isssue with cursor changes impacting Conpherence thread indexing to Fix a straggling issue with cursor changes impacting Conpherence thread indexing.Mar 28 2019, 11:25 PM
amckinley accepted this revision.Mar 28 2019, 11:31 PM
This revision is now accepted and ready to land.Mar 28 2019, 11:31 PM
Closed by commit rPf1a7eb66da36: Fix a straggling issue with cursor changes impacting Conpherence thread indexing (authored by epriestley). · Explain WhyMar 29 2019, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
engineextension/
11 lines

Diff 48552

View Options

src/applications/conpherence/engineextension/ConpherenceThreadIndexEngineExtension.php

Loading...
Phabricator · Built by Phacility