Differential D20212

Fix a stray "%Q" warning when hiding/showing inline comments
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 8:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 3, 2:41 PM

	Unknown Object (File)
	Wed, Nov 27, 10:16 AM

	Unknown Object (File)
	Wed, Nov 27, 1:36 AM

	Unknown Object (File)
	Tue, Nov 26, 10:15 PM

	Unknown Object (File)
	Tue, Nov 26, 10:14 PM

	Unknown Object (File)
	Tue, Nov 26, 10:14 PM

	Unknown Object (File)
	Tue, Nov 26, 10:14 PM

	Unknown Object (File)
	Nov 19 2024, 4:54 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPdc9aaa0fc2bf: Fix a stray "%Q" warning when hiding/showing inline comments

Summary

See PHI1095.

Test Plan

Viewed a revision, toggled hide/show on inline comments. Before: warning in logs; after: smooth sailing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 25 2019, 8:43 PM

Harbormaster completed remote builds in B22122: Diff 48260.Feb 25 2019, 8:44 PM

epriestley requested review of this revision.Feb 25 2019, 8:44 PM

amckinley accepted this revision.Feb 25 2019, 9:45 PM

This revision is now accepted and ready to land.Feb 25 2019, 9:45 PM

Closed by commit rPdc9aaa0fc2bf: Fix a stray "%Q" warning when hiding/showing inline comments (authored by epriestley). · Explain WhyFeb 25 2019, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialInlineCommentEditController.php

4 lines

Diff 48261

View Options

src/applications/differential/controller/DifferentialInlineCommentEditController.php

Fix a stray "%Q" warning when hiding/showing inline commentsClosedPublicActions