Page MenuHomePhabricator

Allow a DAO object storage namespace to be forced to a particular value
ClosedPublic

Authored by epriestley on Feb 14 2019, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:03 AM
Unknown Object (File)
Tue, Dec 17, 4:56 AM
Unknown Object (File)
Mon, Dec 16, 10:03 AM
Unknown Object (File)
Thu, Dec 12, 5:04 PM
Unknown Object (File)
Wed, Dec 11, 7:49 AM
Unknown Object (File)
Sun, Dec 8, 5:21 PM
Unknown Object (File)
Wed, Dec 4, 10:51 AM
Unknown Object (File)
Sat, Nov 30, 7:34 AM
Subscribers
None

Details

Summary

Ref T6703. When we import external data from a third-party install to a Phacility instance, we must link instance accounts to central accounts: either existing central accounts, or newly created central accounts that we send invites for.

During this import, or when users register and claim those new accounts, we do a write from admin.phacility.com directly into the instance database to link the accounts.

This is pretty sketchy, and should almost certainly just be an internal API instead, particularly now that it's relatively stable.

However, it's what we use for now. The process has had some issues since the introduction of %R (combined database name and table refrence in queries), and now needs to be updated for the new providerConfigPHID column in ExternalAccount.

The problem is that %R isn't doing the right thing. We have code like this:

$conn = new_connection_to_instance('turtle');
queryf($conn, 'INSERT INTO %R ...', $table);

However, the $table resolves %R using the currently-executing-process information, not anything specific to $conn, so it prints admin_user.user_externalaccount (the name of the table on admin.phacility.com, where the code is running).

We want it to print turtle_user.user_externalaccount instead: the name of the table on turtle.phacility.com, where we're actually writing.

To force this to happen, let callers override the namespace part of the database name.

Long term: I'd plan to rip this out and replace it with an API call. This "connect directly to the database" stuff is nice for iterating on (only admin needs hotfixes) but very very sketchy for maintaining.

Test Plan

See next diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable