Page MenuHomePhabricator
Differential D20157

Fix specifications of some "Visual Only" elements
ClosedPublic
Actions

Authored by epriestley on Feb 13 2019, 12:40 PM.
Tags
None
Referenced Files
F14077560: D20157.diff
Fri, Nov 22, 12:08 AM
F14076950: D20157.id48145.diff
Thu, Nov 21, 8:37 PM
Unknown Object (File)
Mon, Nov 18, 6:32 AM
Unknown Object (File)
Thu, Nov 14, 8:49 PM
Unknown Object (File)
Sat, Nov 9, 7:41 PM
Unknown Object (File)
Tue, Nov 5, 8:47 PM
Unknown Object (File)
Tue, Oct 29, 4:56 AM
Unknown Object (File)
Oct 21 2024, 11:48 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP88d5233b7776: Fix specifications of some "Visual Only" elements
Summary

See PHI823. These got "visual-only" but should acutally get "aural => false" to pick up "aria-hidden".

Test Plan

Viewed page source, saw both "visual-only" and "aria-hidden".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
view/
5 lines
view/
phui/
5 lines
5 lines

Diff 48145

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/view/phui/PHUIHeadThingView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility