Page MenuHomePhabricator
Differential D20157

Fix specifications of some "Visual Only" elements
ClosedPublic
Actions

Authored by epriestley on Feb 13 2019, 12:40 PM.
Tags
None
Referenced Files
F15451480: D20157.id.diff
Fri, Mar 28, 10:19 PM
F15402093: D20157.id48145.diff
Mon, Mar 17, 8:36 PM
F15390239: D20157.diff
Sat, Mar 15, 6:03 AM
F15381355: D20157.diff
Fri, Mar 14, 7:14 AM
F15377485: D20157.id.diff
Thu, Mar 13, 9:09 AM
Unknown Object (File)
Feb 2 2025, 11:04 AM
Unknown Object (File)
Jan 29 2025, 10:39 AM
Unknown Object (File)
Jan 26 2025, 7:52 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP88d5233b7776: Fix specifications of some "Visual Only" elements
Summary

See PHI823. These got "visual-only" but should acutally get "aural => false" to pick up "aria-hidden".

Test Plan

Viewed page source, saw both "visual-only" and "aria-hidden".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
view/
5 lines
view/
phui/
5 lines
5 lines

Diff 48145

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/view/phui/PHUIHeadThingView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility