Differential D20135

Fix inverted check in audit triggers for "uninvolved owner"
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 2:57 PM.

Tags

None

Referenced Files

	F15449886: D20135.diff
	Fri, Mar 28, 12:40 PM

	F15414299: D20135.id48089.diff
	Thu, Mar 20, 12:04 AM

	F15337624: D20135.diff
	Sun, Mar 9, 6:47 AM

	Unknown Object (File)
	Feb 27 2025, 8:05 AM

	Unknown Object (File)
	Feb 26 2025, 8:26 AM

	Unknown Object (File)
	Feb 9 2025, 7:09 AM

	Unknown Object (File)
	Feb 9 2025, 7:09 AM

	Unknown Object (File)
	Feb 9 2025, 7:09 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP4f40cb0ff9c6: (stable) Fix inverted check in audit triggers for "uninvolved owner"
rP77247084bd36: Fix inverted check in audit triggers for "uninvolved owner"

Summary

See D20126. I was trying to be a little too cute here with the names and ended up confusing myself, then just tested the method behavior. :/

Test Plan

Persudaded by arguments in D20126.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 11 2019, 2:57 PM

Harbormaster completed remote builds in B21915: Diff 48076.Feb 11 2019, 2:59 PM

epriestley requested review of this revision.Feb 11 2019, 2:59 PM

amckinley accepted this revision.Feb 11 2019, 6:12 PM

This revision is now accepted and ready to land.Feb 11 2019, 6:12 PM

Closed by commit rP77247084bd36: Fix inverted check in audit triggers for "uninvolved owner" (authored by epriestley). · Explain WhyFeb 11 2019, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

PhabricatorRepositoryCommitOwnersWorker.php

4 lines

Diff 48089

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Fix inverted check in audit triggers for "uninvolved owner"ClosedPublicActions