Page MenuHomePhabricator
Differential D20135

Fix inverted check in audit triggers for "uninvolved owner"
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 2:57 PM.

Details

Reviewers
amckinley
Commits
rP77247084bd36: Fix inverted check in audit triggers for "uninvolved owner"
rP4f40cb0ff9c6: (stable) Fix inverted check in audit triggers for "uninvolved owner"
Summary

See D20126. I was trying to be a little too cute here with the names and ended up confusing myself, then just tested the method behavior. :/

Test Plan

Persudaded by arguments in D20126.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 11 2019, 2:57 PM
epriestley requested review of this revision.Feb 11 2019, 2:59 PM
amckinley accepted this revision.Feb 11 2019, 6:12 PM
This revision is now accepted and ready to land.Feb 11 2019, 6:12 PM
Closed by commit rP77247084bd36: Fix inverted check in audit triggers for "uninvolved owner" (authored by epriestley). · Explain WhyFeb 11 2019, 10:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48089

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Loading...
Phabricator · Built by Phacility