Differential D20135

Fix inverted check in audit triggers for "uninvolved owner"
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 2:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 9:31 AM

	Unknown Object (File)
	Wed, Jan 15, 12:48 PM

	Unknown Object (File)
	Sun, Jan 12, 4:55 AM

	Unknown Object (File)
	Thu, Jan 9, 11:55 PM

	Unknown Object (File)
	Thu, Jan 9, 12:23 AM

	Unknown Object (File)
	Fri, Dec 27, 5:53 PM

	Unknown Object (File)
	Wed, Dec 25, 3:08 AM

	Unknown Object (File)
	Dec 24 2024, 1:33 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP4f40cb0ff9c6: (stable) Fix inverted check in audit triggers for "uninvolved owner"
rP77247084bd36: Fix inverted check in audit triggers for "uninvolved owner"

Summary

See D20126. I was trying to be a little too cute here with the names and ended up confusing myself, then just tested the method behavior. :/

Test Plan

Persudaded by arguments in D20126.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 11 2019, 2:57 PM

Harbormaster completed remote builds in B21915: Diff 48076.Feb 11 2019, 2:59 PM

epriestley requested review of this revision.Feb 11 2019, 2:59 PM

amckinley accepted this revision.Feb 11 2019, 6:12 PM

This revision is now accepted and ready to land.Feb 11 2019, 6:12 PM

Closed by commit rP77247084bd36: Fix inverted check in audit triggers for "uninvolved owner" (authored by epriestley). · Explain WhyFeb 11 2019, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

PhabricatorRepositoryCommitOwnersWorker.php

4 lines

Diff 48089

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Fix inverted check in audit triggers for "uninvolved owner"ClosedPublicActions