Page MenuHomePhabricator
Differential D20068

Don't load unnecessary handle data on "transaction.search"
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:31 PM
Unknown Object (File)
Wed, Dec 18, 12:45 AM
Unknown Object (File)
Wed, Dec 18, 12:45 AM
Unknown Object (File)
Wed, Dec 18, 12:45 AM
Unknown Object (File)
Sun, Dec 15, 7:55 AM
Unknown Object (File)
Sat, Dec 7, 11:07 AM
Unknown Object (File)
Thu, Nov 28, 7:20 AM
Unknown Object (File)
Nov 24 2024, 1:41 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13242: 2019 Week 5 Bonus Content
Commits
rP942d6d60d5d7: Don't load unnecessary handle data on "transaction.search"
Summary

Ref T13242. Currently, the transaction query loads handles by default (this is unusual). We don't need them, so turn them off.

Test Plan

No apparent behavioral change, will compare production profiles.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 30 2019, 8:20 PM
epriestley added a comment.Jan 30 2019, 8:22 PM

(My case for this and D20067 is a little weak since XHProf isn't running locally until I sort out T13232 by compiling Gentoo nine times, but I think they're almost certainly actual performance improvements and I just wanted to spend a few minutes on it and get rid of anything flagrantly silly.)

Harbormaster completed remote builds in B21768: Diff 47918.Jan 30 2019, 8:22 PM
epriestley requested review of this revision.Jan 30 2019, 8:22 PM
epriestley mentioned this in D20067: Slightly improve performance of querystring construction by caching results.Jan 30 2019, 11:07 PM
amckinley accepted this revision.Feb 1 2019, 3:56 AM
This revision is now accepted and ready to land.Feb 1 2019, 3:56 AM
Closed by commit rP942d6d60d5d7: Don't load unnecessary handle data on "transaction.search" (authored by epriestley). · Explain WhyFeb 1 2019, 4:14 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Feb 1 2019, 4:16 PM

In production against T13242, with ab -n 100 -c 1 ..., I get these before the change:

50th Percentile287ms
95th Percentile380ms

Deploying this now...

epriestley added a comment.Feb 1 2019, 4:23 PM

Now:

50th Percentile179ms
95th Percentile226ms

🐇⚡

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
conduit/
1 line

Diff 47950

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility