Page MenuHomePhabricator

Don't load unnecessary handle data on "transaction.search"
ClosedPublic

Authored by epriestley on Wed, Jan 30, 8:20 PM.

Details

Summary

Ref T13242. Currently, the transaction query loads handles by default (this is unusual). We don't need them, so turn them off.

Test Plan

No apparent behavioral change, will compare production profiles.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jan 30, 8:20 PM

(My case for this and D20067 is a little weak since XHProf isn't running locally until I sort out T13232 by compiling Gentoo nine times, but I think they're almost certainly actual performance improvements and I just wanted to spend a few minutes on it and get rid of anything flagrantly silly.)

epriestley requested review of this revision.Wed, Jan 30, 8:22 PM
amckinley accepted this revision.Fri, Feb 1, 3:56 AM
This revision is now accepted and ready to land.Fri, Feb 1, 3:56 AM
This revision was automatically updated to reflect the committed changes.

In production against T13242, with ab -n 100 -c 1 ..., I get these before the change:

50th Percentile287ms
95th Percentile380ms

Deploying this now...

Now:

50th Percentile179ms
95th Percentile226ms

๐Ÿ‡โšก