Page MenuHomePhabricator

Don't put "spacePHID IN (...)" constraints in queries which will raise policy exceptions
ClosedPublic

Authored by epriestley on Jan 28 2019, 3:52 PM.
Tags
None
Referenced Files
F15428831: D20042.id47856.diff
Sun, Mar 23, 10:39 PM
F15424479: D20042.id47857.diff
Sat, Mar 22, 10:36 PM
F15419954: D20042.id.diff
Fri, Mar 21, 10:04 AM
F15416707: D20042.diff
Thu, Mar 20, 1:04 PM
F15401277: D20042.id47856.diff
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Feb 20 2025, 2:39 AM
Unknown Object (File)
Feb 13 2025, 9:00 PM
Unknown Object (File)
Feb 13 2025, 9:00 PM
Subscribers
None

Details

Summary

See T13240. Ref T13242. When we're issuing a query that will raise policy exceptions (i.e., give the user a "You Shall Not Pass" dialog if they can not see objects it loads), don't do space filtering in MySQL: when objects are filtered out in MySQL, we can't distinguish between "bad/invalid ID/object" and "policy filter", so we can't raise a policy exception.

This leads to cases where viewing an object shows "You Shall Not Pass" if you can't see it for any non-Spaces reason, but "404" if the reason is Spaces.

There's no product reason for this, it's just that spacePHID IN (...) is important for non-policy-raising queries (like a list of tasks) to reduce how much application filtering we need to do.

Test Plan

Before:

$ git pull
phabricator-ssh-exec: No repository "spellbook" exists!
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

After:

$ git pull
phabricator-ssh-exec: [You Shall Not Pass: Unknown Object (Repository)] This object is in a space you do not have permission to access.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable