Page MenuHomePhabricator

Move "Welcome" mail generation out of PhabricatorUser
ClosedPublic

Authored by epriestley on Jan 17 2019, 5:53 PM.
Tags
None
Referenced Files
F18814806: D19989.id47748.diff
Mon, Oct 20, 11:58 PM
F18814805: D19989.id47723.diff
Mon, Oct 20, 11:58 PM
F18814804: D19989.id.diff
Mon, Oct 20, 11:57 PM
F18811608: D19989.diff
Mon, Oct 20, 3:59 AM
F18786858: D19989.id47748.diff
Tue, Oct 14, 8:51 PM
F18751879: D19989.id.diff
Sat, Oct 4, 1:07 PM
F18727233: D19989.id47723.diff
Tue, Sep 30, 7:45 AM
F18698000: D19989.diff
Sat, Sep 27, 10:40 AM
Subscribers
None

Details

Summary

Ref PHI1027. Currently, PhabricatorUser has a couple of mail-related methods which shouldn't really be there in the long term. Immediately, I want to make some adjusments to the welcome email.

Move "Welcome" mail generation to a separate class and consolidate all the error handling. (Eventually, "invite" and "verify address" email should move to similar subclasses, too.) Previously, a bunch of errors/conditions got checked in multiple places.

The only functional change is that we no longer allow you to send welcome mail to disabled users.

Test Plan
  • Used "Send Welcome Mail" from profile pages to send mail.
  • Hit "not admin", "disabled user", "bot/mailing list" errors.
  • Used scripts/user/add_user.php to send welcome mail.
  • Used "Create New User" to send welcome mail.
  • Verified mail with bin/mail show-outbound. (Cleaned up a couple of minor display issues here.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable