Page MenuHomePhabricator

Add infrastructure for sending SMS via AWS SNS
ClosedPublic

Authored by amckinley on Jan 16 2019, 7:09 PM.

Details

Summary

Ref T920. Ref T13235. This adds a Future, similar to TwilioFuture, for interacting with Amazon's SNS service.

Also updates the documentation.

Also makes the code consistent with the documentation by accepting a media argument.

Test Plan

Clicked the "send test message" button from the Settings UI.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Jan 16 2019, 7:09 PM
amckinley requested review of this revision.Jan 16 2019, 7:11 PM
amckinley updated this revision to Diff 47824.Jan 24 2019, 12:05 AM

Clean up to work like TwilioFuture.

amckinley updated this revision to Diff 47825.Jan 24 2019, 12:09 AM

Restore deleted file.

amckinley edited the summary of this revision. (Show Details)Jan 24 2019, 12:10 AM
amckinley edited the test plan for this revision. (Show Details)
amckinley updated this revision to Diff 47826.Jan 24 2019, 12:12 AM

Correct link.

epriestley accepted this revision.Jan 24 2019, 12:12 AM
epriestley added inline comments.
src/applications/metamta/future/PhabricatorAmazonSNSFuture.php
5

Is this actually used?

6

Doesn't necessarily need to be in this diff, but can we put this in PhutilAWSFuture?

src/docs/user/configuration/configuring_outbound_email.diviner
100

(I'll hit this document a bit more broadly for SMS in general at some point, too.)

216

Link to SES instead of SNS?

220

"to the SES configuration"?

src/infrastructure/cluster/config/PhabricatorClusterMailersConfigType.php
48

Ah, thanks.

This revision is now accepted and ready to land.Jan 24 2019, 12:12 AM
amckinley marked 2 inline comments as done.Jan 24 2019, 12:15 AM
amckinley added inline comments.
src/applications/metamta/future/PhabricatorAmazonSNSFuture.php
5

If I implemented getProxiedFuture correctly, I think so?

6

Yeah, good idea.

src/docs/user/configuration/configuring_outbound_email.diviner
216

Hahah I noticed both of these right after submitting.

Oh, I see what's going on with parameters, the base class is just a little bit unusual. Carry on.

This revision was automatically updated to reflect the committed changes.
amckinley marked an inline comment as done.