Differential D19967

Correct a zero-based month tooltip on burnup charts
ClosedPublic
Actions

Authored by epriestley on Jan 14 2019, 5:28 PM.

Details

Reviewers

amckinley

Commits

rP3b94b3e812e7: Correct a zero-based month tooltip on burnup charts

Summary

See PHI1017. This is a trivial fix even though these burnups are headed toward a grisly fate.

Test Plan

Moused over some January datapoints, saw "1" instead of "0".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 14 2019, 5:28 PM

Harbormaster completed remote builds in B21513: Diff 47661.Jan 14 2019, 5:33 PM

epriestley requested review of this revision.Jan 14 2019, 5:33 PM

amckinley accepted this revision.Jan 16 2019, 2:00 AM

This revision is now accepted and ready to land.Jan 16 2019, 2:00 AM

Closed by commit rP3b94b3e812e7: Correct a zero-based month tooltip on burnup charts (authored by epriestley). · Explain WhyJan 16 2019, 2:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

applications/

maniphest/

controller/

ManiphestReportController.php

5 lines

webroot/

rsrc/

js/

application/

maniphest/

behavior-line-chart.js

5 lines

Diff 47677

View Options

resources/celerity/map.php

View Options

src/applications/maniphest/controller/ManiphestReportController.php

View Options

webroot/rsrc/js/application/maniphest/behavior-line-chart.js

Correct a zero-based month tooltip on burnup chartsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47677

resources/celerity/map.php

src/applications/maniphest/controller/ManiphestReportController.php

webroot/rsrc/js/application/maniphest/behavior-line-chart.js

Correct a zero-based month tooltip on burnup charts
ClosedPublic
Actions

Revision Contents
Changeset List