Differential D19962

call qsprintf() without warnings
ClosedPublic
Actions

Authored by MarcLindenberg on Jan 10 2019, 2:17 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP360ebce00fe8: call qsprintf() without warnings

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

After T13217 import_repository_symbols.php was showing a lot of warnings, using %LQ fixes that.
I'm aware, that there are changes planned to the whole managing the symbols complex but until then less warnings are nice.

Test Plan

No more warnings when updating symbols

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21506
Build 29298: arc lint + arc unit

Event Timeline

MarcLindenberg created this revision.Jan 10 2019, 2:17 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 10 2019, 2:17 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

MarcLindenberg requested review of this revision.Jan 10 2019, 2:17 PM

Harbormaster completed remote builds in B21506: Diff 47654.Jan 10 2019, 2:17 PM

Thanks!

This revision is now accepted and ready to land.Jan 14 2019, 5:41 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 14 2019, 5:41 PM

Closed by commit rP360ebce00fe8: call qsprintf() without warnings (authored by MarcLindenberg, committed by epriestley). · Explain WhyJan 14 2019, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

symbols/

import_repository_symbols.php

4 lines

Diff 47654

View Options

scripts/symbols/import_repository_symbols.php

call qsprintf() without warningsClosedPublicActions