Paths

Table of Contentst

Differential D19959

Update Mailgun adapter for the new mail adapter API
ClosedPublic
Actions

Authored by epriestley on Jan 5 2019, 12:59 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T920: Provide SMS Support
T5969: Add timeouts to service calls to external mailers (was: PhabricatorMetaMTAWorker may hang indefinitely if "sendmail" hangs indefinitely)

Commits

rPd7da3560ec56: Update Mailgun adapter for the new mail adapter API

Summary

Ref T920. Ref T5969. Update the Mailgun adapter for the API changes and add a timeout.

Test Plan

Configured Mailgun as a mailer, sent mail with subject/to/cc/headers/html/attachments using bin/mail send-test.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 5 2019, 12:59 PM

Harbormaster completed remote builds in B21500: Diff 47646.Jan 5 2019, 1:01 PM

epriestley requested review of this revision.Jan 5 2019, 1:01 PM

amckinley accepted this revision.Jan 10 2019, 4:32 PM

amckinley added inline comments.

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
42	Shouldn't this be `if (strlen($subject))`?
76	Unused variable.
84	Another `strlen`?
89	Another `strlen`?

This revision is now accepted and ready to land.Jan 10 2019, 4:32 PM

epriestley added inline comments.Jan 14 2019, 10:19 PM

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
42	As currently written, `setSubject('')` will generate a `Subject:` header, which seems more faithful to intent than `strlen()`. I think this is probably moot in practice and (below) sending a mail with (say) an empty-but-present text body is probably weird/a mistake, but it's technically a valid construction. If there's ambiguity in practice, I think it's likely better resolved at a higher level (during message construction, e.g.)

Remove unused variable.

Harbormaster completed remote builds in B21523: Diff 47670.Jan 14 2019, 10:21 PM

amckinley mentioned this in D19965: Update the "SES" and "sendmail" mailers for the new API; remove "encoding".Jan 16 2019, 7:16 PM

Closed by commit rPd7da3560ec56: Update Mailgun adapter for the new mail adapter API (authored by epriestley). · Explain WhyJan 16 2019, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailMailgunAdapter.php

146 lines

Diff 47701

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php

Loading...