Page MenuHomePhabricator

Update Mailgun adapter for the new mail adapter API
ClosedPublic

Authored by epriestley on Jan 5 2019, 12:59 PM.
Tags
None
Referenced Files
F18736127: D19959.id47646.diff
Wed, Oct 1, 4:56 AM
F18683399: D19959.id47670.diff
Fri, Sep 26, 7:35 AM
F18683395: D19959.id47701.diff
Fri, Sep 26, 7:34 AM
F18569105: D19959.id47701.diff
Wed, Sep 10, 12:59 AM
F18569104: D19959.id47670.diff
Wed, Sep 10, 12:59 AM
F18569103: D19959.id47646.diff
Wed, Sep 10, 12:59 AM
F18566771: D19959.id.diff
Tue, Sep 9, 2:53 PM
F18517670: D19959.diff
Fri, Sep 5, 1:47 PM
Subscribers
None

Details

Summary

Ref T920. Ref T5969. Update the Mailgun adapter for the API changes and add a timeout.

Test Plan

Configured Mailgun as a mailer, sent mail with subject/to/cc/headers/html/attachments using bin/mail send-test.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43

Shouldn't this be if (strlen($subject))?

77

Unused variable.

85

Another strlen?

90

Another strlen?

This revision is now accepted and ready to land.Jan 10 2019, 4:32 PM
src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43

As currently written, setSubject('') will generate a Subject: header, which seems more faithful to intent than strlen(). I think this is probably moot in practice and (below) sending a mail with (say) an empty-but-present text body is probably weird/a mistake, but it's technically a valid construction. If there's ambiguity in practice, I think it's likely better resolved at a higher level (during message construction, e.g.)

This revision was automatically updated to reflect the committed changes.