Page MenuHomePhabricator

Update Mailgun adapter for the new mail adapter API
ClosedPublic

Authored by epriestley on Jan 5 2019, 12:59 PM.
Tags
None
Referenced Files
F15515353: D19959.diff
Fri, Apr 18, 9:51 AM
F15507331: D19959.id47701.diff
Tue, Apr 15, 6:44 PM
F15507255: D19959.id47646.diff
Tue, Apr 15, 5:54 PM
F15504523: D19959.id47701.diff
Mon, Apr 14, 6:36 PM
F15503698: D19959.id47670.diff
Mon, Apr 14, 12:12 PM
F15502965: D19959.id.diff
Mon, Apr 14, 5:46 AM
F15469358: D19959.diff
Fri, Apr 4, 12:22 PM
F15468135: D19959.id47646.diff
Thu, Apr 3, 8:35 PM
Subscribers
None

Details

Summary

Ref T920. Ref T5969. Update the Mailgun adapter for the API changes and add a timeout.

Test Plan

Configured Mailgun as a mailer, sent mail with subject/to/cc/headers/html/attachments using bin/mail send-test.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43

Shouldn't this be if (strlen($subject))?

77

Unused variable.

85

Another strlen?

90

Another strlen?

This revision is now accepted and ready to land.Jan 10 2019, 4:32 PM
src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43

As currently written, setSubject('') will generate a Subject: header, which seems more faithful to intent than strlen(). I think this is probably moot in practice and (below) sending a mail with (say) an empty-but-present text body is probably weird/a mistake, but it's technically a valid construction. If there's ambiguity in practice, I think it's likely better resolved at a higher level (during message construction, e.g.)

This revision was automatically updated to reflect the committed changes.