Page MenuHomePhabricator

Update Mailgun adapter for the new mail adapter API
ClosedPublic

Authored by epriestley on Jan 5 2019, 12:59 PM.
Tags
None
Referenced Files
F17898781: D19959.id47701.diff
Tue, Jul 29, 8:20 AM
F17866969: D19959.id.diff
Mon, Jul 28, 5:14 AM
Unknown Object (File)
May 25 2025, 7:12 PM
Unknown Object (File)
May 25 2025, 7:11 PM
Unknown Object (File)
May 25 2025, 12:49 PM
Unknown Object (File)
May 20 2025, 5:52 AM
Unknown Object (File)
May 19 2025, 5:27 AM
Unknown Object (File)
May 9 2025, 12:22 PM
Subscribers
None

Details

Summary

Ref T920. Ref T5969. Update the Mailgun adapter for the API changes and add a timeout.

Test Plan

Configured Mailgun as a mailer, sent mail with subject/to/cc/headers/html/attachments using bin/mail send-test.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43

Shouldn't this be if (strlen($subject))?

77

Unused variable.

85

Another strlen?

90

Another strlen?

This revision is now accepted and ready to land.Jan 10 2019, 4:32 PM
src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43

As currently written, setSubject('') will generate a Subject: header, which seems more faithful to intent than strlen(). I think this is probably moot in practice and (below) sending a mail with (say) an empty-but-present text body is probably weird/a mistake, but it's technically a valid construction. If there's ambiguity in practice, I think it's likely better resolved at a higher level (during message construction, e.g.)

This revision was automatically updated to reflect the committed changes.