Page MenuHomePhabricator

Consolidate some application email receiver code in preparation for API changes
ClosedPublic

Authored by epriestley on Thu, Jan 3, 5:56 PM.

Details

Summary

Ref T7477. The various "create a new X via email" applications (Paste, Differential, Maniphest, etc) all have a bunch of duplicate code.

The inheritance stack here is generally a little weird. Extend these from a shared parent to reduce the number of callsites I need to change when this API is adjusted for T7477.

Test Plan

Ran unit tests. This will get more thorough testing once more pieces are in place.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jan 3, 5:56 PM
epriestley requested review of this revision.Thu, Jan 3, 5:58 PM
amckinley accepted this revision.Fri, Jan 4, 12:01 AM
This revision is now accepted and ready to land.Fri, Jan 4, 12:01 AM
This revision was automatically updated to reflect the committed changes.