Page MenuHomePhabricator

Remove old Phrequent propery rendering code and show "Time Spent" in higher precision
ClosedPublic

Authored by epriestley on Sat, Dec 22, 11:57 AM.

Details

Summary

See https://discourse.phabricator-community.org/t/how-to-get-total-time-spent-on-a-task-in-minutes-or-hours/2241.

Phrequent has two nearly-identical copies of its rendering code: one for old "property event" objects and one for newer "curtain" objects. In the upstream, both trackable object types (tasks and revisions) use curtains, so throw away the old code since it isn't reachable. Third-party trackable objects can update to the curtain UI, but it's unlikely they exist.

Render the remaining curtain UI with more precision, so we show "Time Spent: 2d, 11h, 49m" instead of "Time Spent: 2d".

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Dec 22, 11:57 AM
epriestley requested review of this revision.Sat, Dec 22, 11:59 AM
epriestley added inline comments.Sat, Dec 22, 2:09 PM
src/applications/phrequent/engineextension/PhrequentCurtainExtension.php
16

(This method is largely identical to the removed method, below. It renders into the newer "curtain" sidebar element; the old one rendered directly into the main column's list of properties.)

amckinley accepted this revision.Mon, Dec 24, 10:14 PM
This revision is now accepted and ready to land.Mon, Dec 24, 10:14 PM
This revision was automatically updated to reflect the committed changes.