Page MenuHomePhabricator

Cleanup some clustering rough edges
ClosedPublic

Authored by amckinley on Dec 20 2018, 12:26 AM.

Details

Summary

Suppress an unhelpful Almanac transaction and document the location of the secret clustering management capability. I thought maybe implementing shouldHide and checking for isCreate would work, but the binding apparently gets created before an interface is bound to it.

Test Plan

Looked at a fresh binding and didn't see "Unknown Object(??)", ran bin/diviner and saw expected output.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Dec 20 2018, 12:26 AM
amckinley requested review of this revision.Dec 20 2018, 12:28 AM
epriestley accepted this revision.Dec 20 2018, 2:53 PM
epriestley added inline comments.
src/applications/almanac/xaction/AlmanacBindingInterfaceTransaction.php
59–62

Some day, this transaction will be marked as TYPE_CREATE and hidden, but adding a better rendering to it is quite reasonable for now (and maybe we'll go back and add more of these if we let you render hidden transactions with transaction.search at some point).

63–66

I think removing an interface is impossible so this code is unreachable.

This revision is now accepted and ready to land.Dec 20 2018, 2:53 PM
This revision was automatically updated to reflect the committed changes.