Page MenuHomePhabricator

Cleanup some clustering rough edges
ClosedPublic

Authored by amckinley on Dec 20 2018, 12:26 AM.
Tags
None
Referenced Files
F15505795: D19917.id47540.diff
Tue, Apr 15, 5:56 AM
F15504921: D19917.id.diff
Mon, Apr 14, 10:31 PM
F15496859: D19917.diff
Sun, Apr 13, 8:30 AM
F15484212: D19917.diff
Wed, Apr 9, 5:09 PM
F15480110: D19917.id.diff
Tue, Apr 8, 11:47 AM
F15375192: D19917.id.diff
Mar 12 2025, 10:09 PM
F15375045: D19917.diff
Mar 12 2025, 9:22 PM
Unknown Object (File)
Mar 3 2025, 3:11 PM
Subscribers

Details

Summary

Suppress an unhelpful Almanac transaction and document the location of the secret clustering management capability. I thought maybe implementing shouldHide and checking for isCreate would work, but the binding apparently gets created before an interface is bound to it.

Test Plan

Looked at a fresh binding and didn't see "Unknown Object(??)", ran bin/diviner and saw expected output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley added inline comments.
src/applications/almanac/xaction/AlmanacBindingInterfaceTransaction.php
59–62

Some day, this transaction will be marked as TYPE_CREATE and hidden, but adding a better rendering to it is quite reasonable for now (and maybe we'll go back and add more of these if we let you render hidden transactions with transaction.search at some point).

63–66

I think removing an interface is impossible so this code is unreachable.

This revision is now accepted and ready to land.Dec 20 2018, 2:53 PM
This revision was automatically updated to reflect the committed changes.