Show more of UTC offset when user's TZ is not an integer number of hours offset
ClosedPublic
Actions

Authored by amckinley on Dec 12 2018, 9:20 PM.

Details

Reviewers

epriestley

Commits

rP5cb462d511c7: Show more of UTC offset when user's TZ is not an integer number of hours offset

Summary

See https://discourse.phabricator-community.org/t/personal-timezone-setting-mismatch-cleared-and-more-specific-cases/1680. The code has always worked correctly, but the resulting timezone mismatch warning messsage wasn't specific enough when the mismatch is by a non-integer number of hours.

Test Plan

Set timezone locally to Asia/Vladivostok and in Phabricator to Australia/Adelaide (which as of today's date are 30 minutes apart) and observed a more precise error message: F6061330

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Dec 12 2018, 9:20 PM

Harbormaster completed remote builds in B21309: Diff 47458.Dec 12 2018, 9:21 PM

amckinley requested review of this revision.Dec 12 2018, 9:21 PM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2018, 9:21 PM

I didn't know about %+, neat.

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
119	Maybe this should be `%+0.2f` since 3h 15m will render as `3.2` or `3.3` right now. Or maybe (something like) `%+d:%02d` with the remainder, so we get `+3:15`, `+3:30` and `+3:45` instead of `+3.25`, `+3.5` and `+3.75` -- that seems marginally clearer?