Don't allow the middle mouse button to start an inline comment
ClosedPublic
Actions

Authored by epriestley on Nov 24 2018, 3:02 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rP8b550ce2cd8f: Don't allow the middle mouse button to start an inline comment

Summary

Ref T13216. See PHI985. When you click a line number to start an inline comment, we intend to initiate the action only if you used the left mouse button (desktop) or a touch (tablet/device).

We currently have a not right condition for doing this, but it only excludes right clicks, not middle clicks (or other nth-button clicks). The not right condition was sligthly easier to write, but use an is left condition instead of a not right condition.

Test Plan

In Safari, Firefox and Chrome:
- Used left click to start an inline.
- Used middle click to do nothing (previously: started an inline).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 24 2018, 3:02 PM

epriestley marked an inline comment as done.Nov 24 2018, 3:04 PM

epriestley added inline comments.

webroot/rsrc/externals/javelin/core/Event.js
146	I'm not 100% this definition works in old IE, but it's the best guess I could dig up from a few minutes of Googling and we don't really support old IE anyway.