Page MenuHomePhabricator

Allow "Abandoned" revisions to be commandeered
ClosedPublic

Authored by epriestley on Sat, Nov 24, 2:53 PM.

Details

Summary

Ref T13216. See PHI985. You currently can't commandeer an abandoned revision, but this workflow is perfectly fine.

The caution here is just around weird use cases where, e.g., users want to reopen a revision to add a revert to it. These workflows tend to create problems so we try to guide users away from them.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Nov 24, 2:53 PM
epriestley requested review of this revision.Sat, Nov 24, 2:54 PM
amckinley accepted this revision.Mon, Nov 26, 4:50 PM
This revision is now accepted and ready to land.Mon, Nov 26, 4:50 PM
This revision was automatically updated to reflect the committed changes.