Page MenuHomePhabricator
Differential D19825

Expose "identifiers" as a query constraint for Commit search
ClosedPublic
Actions

Authored by epriestley on Nov 21 2018, 4:48 PM.
Tags
None
Referenced Files
F15438317: D19825.id.diff
Wed, Mar 26, 12:07 AM
F15436247: D19825.id.diff
Tue, Mar 25, 12:53 PM
F15429439: D19825.diff
Mon, Mar 24, 2:17 AM
F15426338: D19825.diff
Sun, Mar 23, 8:03 AM
F15399832: D19825.id47349.diff
Mon, Mar 17, 8:00 AM
F15380990: D19825.diff
Fri, Mar 14, 5:21 AM
F15308856: D19825.id.diff
Thu, Mar 6, 6:44 AM
Unknown Object (File)
Mon, Mar 3, 7:54 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
Commits
rP45e93c8f1d1a: Expose "identifiers" as a query constraint for Commit search
Summary

Ref T13216. See PHI984. The CommitSearchEngine (and, by extension, diffusion.commit.search) currently do not support identifier search, but this is a reasonable capability to provide.

Test Plan

Testing that a commit exists on master:

Screen Shot 2018-11-21 at 8.46.19 AM.png (1×2 px, 230 KB)

Same commit is not on stable:

Screen Shot 2018-11-21 at 8.46.36 AM.png (1×2 px, 159 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
13 lines

Diff 47362

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
Phabricator · Built by Phacility