Page MenuHomePhabricator
Differential D19825

Expose "identifiers" as a query constraint for Commit search
ClosedPublic
Actions

Authored by epriestley on Nov 21 2018, 4:48 PM.
Tags
None
Referenced Files
F15543582: D19825.id.diff
Fri, Apr 25, 11:29 PM
F15539248: D19825.diff
Fri, Apr 25, 12:16 AM
F15514819: D19825.id47349.diff
Fri, Apr 18, 5:34 AM
F15500364: D19825.id47350.diff
Sun, Apr 13, 5:37 PM
F15475650: D19825.id47362.diff
Sun, Apr 6, 9:18 PM
F15473460: D19825.id47350.diff
Sat, Apr 5, 10:11 PM
F15438317: D19825.id.diff
Mar 26 2025, 12:07 AM
F15436247: D19825.id.diff
Mar 25 2025, 12:53 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
Commits
rP45e93c8f1d1a: Expose "identifiers" as a query constraint for Commit search
Summary

Ref T13216. See PHI984. The CommitSearchEngine (and, by extension, diffusion.commit.search) currently do not support identifier search, but this is a reasonable capability to provide.

Test Plan

Testing that a commit exists on master:

Screen Shot 2018-11-21 at 8.46.19 AM.png (1×2 px, 230 KB)

Same commit is not on stable:

Screen Shot 2018-11-21 at 8.46.36 AM.png (1×2 px, 159 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
13 lines

Diff 47362

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
Phabricator · Built by Phacility