Page MenuHomePhabricator

Expose "identifiers" as a query constraint for Commit search
ClosedPublic

Authored by epriestley on Wed, Nov 21, 4:48 PM.

Details

Summary

Ref T13216. See PHI984. The CommitSearchEngine (and, by extension, diffusion.commit.search) currently do not support identifier search, but this is a reasonable capability to provide.

Test Plan

Testing that a commit exists on master:

Same commit is not on stable:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Nov 21, 4:48 PM
epriestley requested review of this revision.Wed, Nov 21, 4:50 PM
epriestley updated this revision to Diff 47350.Wed, Nov 21, 4:53 PM
  • Slightly better identifiers, fewer documentation typos.
amckinley accepted this revision.Fri, Nov 23, 2:24 PM
This revision is now accepted and ready to land.Fri, Nov 23, 2:24 PM
This revision was automatically updated to reflect the committed changes.