Page MenuHomePhabricator

Expose "identifiers" as a query constraint for Commit search

Authored by epriestley on Nov 21 2018, 4:48 PM.



Ref T13216. See PHI984. The CommitSearchEngine (and, by extension, currently do not support identifier search, but this is a reasonable capability to provide.

Test Plan

Testing that a commit exists on master:

Same commit is not on stable:

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 21 2018, 4:48 PM
epriestley requested review of this revision.Nov 21 2018, 4:50 PM
epriestley updated this revision to Diff 47350.Nov 21 2018, 4:53 PM
  • Slightly better identifiers, fewer documentation typos.
amckinley accepted this revision.Nov 23 2018, 2:24 PM
This revision is now accepted and ready to land.Nov 23 2018, 2:24 PM
This revision was automatically updated to reflect the committed changes.