Page MenuHomePhabricator

Replace the primary "Disabled/Enabled" Herald Rule filter with "Active/Inactive", considering author status
ClosedPublic

Authored by epriestley on Wed, Nov 14, 11:11 PM.

Details

Summary

Ref T13216. See PHI947. In Herald, Personal rules do not run if their author's account is disabled.

This isn't communicated very clearly in the UI, and the way the SearchEngine/Query are set up isn't great.

Define "active" as "rule will actually run", which specifically means "rule is enabled, and has a valid (non-disabled) author if it needs one".

Change the meaning of the "Active" default filter from "rule is enabled" to "rule is enabled, and has a valid author if it needs one".

Refine the status badge on the view controller to show this "invalid author" state.

Tweak the language for "Disable/Enable" to be more consistent -- we currently call it "disabled" in some cases and "archived" in others.

Test Plan
  • Disabled a user account and saw their personal rules behave properly with the new filters/options/view controller.
  • Disabled/enabled a rule, saw consistent text.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Nov 14, 11:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 14, 11:11 PM
Harbormaster failed remote builds in B21147: Diff 47298!
epriestley requested review of this revision.Wed, Nov 14, 11:27 PM

Stacked on qsprintf().

amckinley accepted this revision.Thu, Nov 15, 8:12 PM
This revision is now accepted and ready to land.Thu, Nov 15, 8:12 PM
This revision was automatically updated to reflect the committed changes.