Page MenuHomePhabricator

Replace the primary "Disabled/Enabled" Herald Rule filter with "Active/Inactive", considering author status
ClosedPublic

Authored by epriestley on Nov 14 2018, 11:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 5:20 PM
Unknown Object (File)
Mon, Nov 18, 12:06 AM
Unknown Object (File)
Sat, Nov 16, 9:33 AM
Unknown Object (File)
Mon, Nov 11, 6:09 PM
Unknown Object (File)
Fri, Nov 8, 12:50 AM
Unknown Object (File)
Mon, Oct 28, 7:11 PM
Unknown Object (File)
Oct 9 2024, 10:36 AM
Unknown Object (File)
Sep 19 2024, 6:27 PM
Subscribers
None

Details

Summary

Ref T13216. See PHI947. In Herald, Personal rules do not run if their author's account is disabled.

This isn't communicated very clearly in the UI, and the way the SearchEngine/Query are set up isn't great.

Define "active" as "rule will actually run", which specifically means "rule is enabled, and has a valid (non-disabled) author if it needs one".

Change the meaning of the "Active" default filter from "rule is enabled" to "rule is enabled, and has a valid author if it needs one".

Refine the status badge on the view controller to show this "invalid author" state.

Tweak the language for "Disable/Enable" to be more consistent -- we currently call it "disabled" in some cases and "archived" in others.

Test Plan
  • Disabled a user account and saw their personal rules behave properly with the new filters/options/view controller.
  • Disabled/enabled a rule, saw consistent text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 14 2018, 11:11 PM
Harbormaster failed remote builds in B21147: Diff 47298!

Stacked on qsprintf().

This revision is now accepted and ready to land.Nov 15 2018, 8:12 PM
This revision was automatically updated to reflect the committed changes.