Page MenuHomePhabricator

When `{meme ...}` embed has no text, just use the raw file data unmodified
ClosedPublic

Authored by epriestley on Nov 6 2018, 5:13 PM.
Tags
None
Referenced Files
F17795081: D19777.id47242.diff
Fri, Jul 25, 12:07 AM
F17752567: D19777.diff
Tue, Jul 22, 7:20 AM
F17751997: D19777.diff
Tue, Jul 22, 6:21 AM
F17612215: D19777.diff
Wed, Jul 9, 9:32 AM
Unknown Object (File)
Jul 1 2025, 10:09 PM
Unknown Object (File)
Jul 1 2025, 9:24 AM
Unknown Object (File)
Jul 1 2025, 8:46 AM
Unknown Object (File)
Jul 1 2025, 8:13 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI948. When you use the remarkup hint button to embed a meme with no text, you get {meme src=X}.

If the source is a GIF, we currently split the source apart into frame-by-frame images, process them, and stitch them back together. The end result is the same image we started with, but this process can be slow/expensive, and may timeout for sufficiently large GIFs.

Instead: when there's no text, just return the original image data.

Test Plan
  • Used {meme src=X} with no text, got an image faster.
  • Used {meme src=X, above=...} to add text, got an attempt to add text (which didn't get very far locally since I don't have GD configured).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable