Page MenuHomePhabricator

When `{meme ...}` embed has no text, just use the raw file data unmodified
ClosedPublic

Authored by epriestley on Nov 6 2018, 5:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:44 PM
Unknown Object (File)
Tue, Mar 19, 3:44 PM
Unknown Object (File)
Sun, Mar 10, 3:46 AM
Unknown Object (File)
Thu, Mar 7, 5:52 AM
Unknown Object (File)
Feb 3 2024, 7:45 PM
Unknown Object (File)
Jan 10 2024, 3:09 AM
Unknown Object (File)
Dec 27 2023, 12:54 PM
Unknown Object (File)
Dec 22 2023, 12:38 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI948. When you use the remarkup hint button to embed a meme with no text, you get {meme src=X}.

If the source is a GIF, we currently split the source apart into frame-by-frame images, process them, and stitch them back together. The end result is the same image we started with, but this process can be slow/expensive, and may timeout for sufficiently large GIFs.

Instead: when there's no text, just return the original image data.

Test Plan
  • Used {meme src=X} with no text, got an image faster.
  • Used {meme src=X, above=...} to add text, got an attempt to add text (which didn't get very far locally since I don't have GD configured).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable