Page MenuHomePhabricator

When `{meme ...}` embed has no text, just use the raw file data unmodified
ClosedPublic

Authored by epriestley on Nov 6 2018, 5:13 PM.
Tags
None
Referenced Files
F18803760: D19777.diff
Sat, Oct 18, 3:40 AM
F18798699: D19777.id.diff
Fri, Oct 17, 7:53 AM
F18784423: D19777.id47242.diff
Mon, Oct 13, 12:29 PM
F18759070: D19777.diff
Mon, Oct 6, 1:35 AM
F18733819: D19777.id.diff
Tue, Sep 30, 10:42 PM
F18568696: D19777.id47242.diff
Sep 10 2025, 12:22 AM
F18568693: D19777.id47238.diff
Sep 10 2025, 12:22 AM
F18509907: D19777.id.diff
Sep 5 2025, 3:40 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI948. When you use the remarkup hint button to embed a meme with no text, you get {meme src=X}.

If the source is a GIF, we currently split the source apart into frame-by-frame images, process them, and stitch them back together. The end result is the same image we started with, but this process can be slow/expensive, and may timeout for sufficiently large GIFs.

Instead: when there's no text, just return the original image data.

Test Plan
  • Used {meme src=X} with no text, got an image faster.
  • Used {meme src=X, above=...} to add text, got an attempt to add text (which didn't get very far locally since I don't have GD configured).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable