Page MenuHomePhabricator

Infer language from filename in Remarkup code blocks
Changes PlannedPublicDraft

Authored by joshuaspence on Nov 1 2018, 12:05 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently Remarkup code blocks don't respect syntax.filemap. This was raised internally when it was noticed that the following code block is not syntax highlighted without adding lang=typescript.

```name=test.ts
function greeter(person) {
    return "Hello, " + person;
}

let user = "Jane User";

document.body.innerHTML = greeter(user);
Test Plan

Saw syntax highlighting for the above code blocjk

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint OK
Unit
Unit Tests Skipped
Build Status
Buildable 21066
Build 28624: Run Core Tests
Build 28623: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Nov 1 2018, 12:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 1 2018, 12:06 AM
Harbormaster failed remote builds in B21066: Diff 47218!

I think the tests may have failed because I did --skip-staging.