Page MenuHomePhabricator

Further refine the Java syntax lexer for escaped strings
ClosedPublic

Authored by epriestley on Oct 25 2018, 4:32 PM.

Details

Summary

Ref T13210. See PHI886. Previously, D19731 improved some behavior here, but didn't go quite far enough and we still got strings with \" wrong.

Parse backslash followed by anything, or any character except double quote or backslash.

(If this is still somehow wrong I can just copy one of the other lexers which is a little more complicated but gets this right.)

Test Plan

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 25 2018, 4:32 PM
epriestley requested review of this revision.Oct 25 2018, 4:32 PM
This revision is now accepted and ready to land.Oct 26 2018, 9:33 PM
This revision was automatically updated to reflect the committed changes.