Page MenuHomePhabricator

[Wilds] Rename "formatters" to "sinks" and restore the console output sufficiently to see which tests are failing
ClosedPublic

Authored by epriestley on Sep 26 2018, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:23 PM
Unknown Object (File)
Sat, Nov 16, 12:46 AM
Unknown Object (File)
Tue, Nov 12, 3:27 PM
Unknown Object (File)
Thu, Nov 7, 11:55 PM
Unknown Object (File)
Oct 21 2024, 7:32 PM
Unknown Object (File)
Oct 9 2024, 10:17 AM
Unknown Object (File)
Sep 7 2024, 12:55 AM
Unknown Object (File)
Sep 6 2024, 4:05 AM
Subscribers
None

Details

Summary

Ref T13098. Since I plan to implement "send the results to Harbormaster" as another type of formatter/output/sink, just rename the objects which receive unit test results and print/write/transmit them into "Sinks" (in the sense of Source/Sink).

Get the default console sink working well enough to see what's failing. As with all other changes in this series this is very rough, but the general idea is that I want to:

  • Let sinks stream both ongoing status information and final results.
  • For the console output, try to increase the signal-to-noise ratio of the output stream. Today, it's too easy to lose a failed test in the results. I want to improve this by outputting less frequently and summarizing passes ("93 tests passed.") so that the streaming output mostly shows failures and it's easier to make a decision to ^C and revise if you see something you don't like.
  • Also, add a summary mode at the end which makes sure failures show up on the console and aren't scrolled up 30 pages. For now, this is quite rough.
Test Plan
373 PASSED * 16 SKIPPED * 162 FAILED/BROKEN/UNSTABLE

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
amckinley added inline comments.
src/unit/sink/ArcanistDefaultUnitSink.php
7

I slightly prefer SINK_KEY here. SINKKEY has kind of a nautical disaster flavor to it, don't you think?

This revision is now accepted and ready to land.Sep 26 2018, 9:35 PM
epriestley added inline comments.
src/unit/sink/ArcanistDefaultUnitSink.php
7

This is for consistentency with a lot of existing TYPECONST, EDGECONST, ENGINEKEY stuff, although I agree that SINKKEY reads pretty weirdly.

This revision was automatically updated to reflect the committed changes.