Page MenuHomePhabricator

[Wilds] Make "arc call-conduit ..." call Conduit methods
ClosedPublic

Authored by epriestley on Sep 20 2018, 10:07 PM.

Details

Summary

Ref T13098. This repairs Conduit integration. Conduit was meaningfully updated in the experimental branch so a lot of this is just deleting code I don't plan to support going forward.

This removes "conduit.timeout", "http.basicauth.user" and "http.basicauth.pass". I believe these were all crazy niche calls with essentially no legitimate use. We could provide extension support if anyone actually uses this stuff, now.

Fixes an old "phutil" reference in HTTPSFuture.

Builds Conduit engine support into ArcanistWorkflow. There's perhaps some argument for trying to not make this core, but every upstream thing we'll ever write probably wants it (arc, phage) and there's not much of a cost to making it core. Even non-core stuff may include extensions which expect Conduit support (for example, for reporting workflow metrics to Phabricator).

There's no authentication support yet, I'm planning to update "hosts" config handling next.

Test Plan
$ echo '{}' | arc call-conduit conduit.ping
 WARNING  Ignoring unrecognized configuration option ("hosts") from source: User Config File (/Users/epriestley/.arcrc).
 WARNING  Ignoring unrecognized configuration option ("load") from source: Project Config File (/Users/epriestley/dev/core/.arcconfig).
{
  "error": null,
  "errorMessage": null,
  "response": "secure001.phacility.net"
}

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley requested review of this revision.Sep 20 2018, 10:07 PM
epriestley created this revision.
amckinley accepted this revision.Sep 21 2018, 4:44 PM
This revision is now accepted and ready to land.Sep 21 2018, 4:44 PM
This revision was automatically updated to reflect the committed changes.