Page MenuHomePhabricator

[Wilds] Slightly simplify fatal handling during "arc" setup
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:10 PM.
Tags
None
Referenced Files
F13973196: D19693.id47047.diff
Thu, Oct 17, 11:38 PM
F13960787: D19693.diff
Tue, Oct 15, 1:23 AM
Unknown Object (File)
Oct 9 2024, 10:11 AM
Unknown Object (File)
Sep 21 2024, 4:15 AM
Unknown Object (File)
Sep 14 2024, 7:27 AM
Unknown Object (File)
Sep 9 2024, 12:12 PM
Unknown Object (File)
Sep 6 2024, 4:01 AM
Unknown Object (File)
Sep 6 2024, 4:01 AM
Subscribers
None

Details

Summary

Ref T13098. We currently handle fatals by printing a message and returning an error code, since this was the most direct adaptation from the old arcanist.php script.

Instead, throw an exception and then handle it above, since we can reasonably do that in one place now.

Test Plan

Ran arc.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2018, 8:10 PM
Harbormaster failed remote builds in B20859: Diff 47047!
This revision is now accepted and ready to land.Sep 20 2018, 12:01 AM
This revision was automatically updated to reflect the committed changes.