Page MenuHomePhabricator

[Wilds] Slightly simplify fatal handling during "arc" setup
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:10 PM.

Details

Summary

Ref T13098. We currently handle fatals by printing a message and returning an error code, since this was the most direct adaptation from the old arcanist.php script.

Instead, throw an exception and then handle it above, since we can reasonably do that in one place now.

Test Plan

Ran arc.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 18 2018, 8:10 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2018, 8:10 PM
Harbormaster failed remote builds in B20859: Diff 47047!
epriestley requested review of this revision.Sep 18 2018, 8:10 PM
amckinley accepted this revision.Sep 20 2018, 12:01 AM
This revision is now accepted and ready to land.Sep 20 2018, 12:01 AM
This revision was automatically updated to reflect the committed changes.