[Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way
ClosedPublic
Actions

Authored by epriestley on Sep 18 2018, 7:53 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13098: Plans: Arcanist toolsets and extensions

Commits

rARCd9362570189e: [Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way

Summary

Ref T13098. Currently, WorkingCopyIdentity has rules for finding .git/.svn/.hg directories and .arcconfig files. It also has a ton of logic for reading and writing config files.

Generally:

Rename WorkingCopyIdentity to WorkingCopy.
Make it an abstract base with Git, Mercurial and Subversion subclasses, using the standard module/extension pattern.
Throw out almost all of the config file logic. This logic is going to move into Config classes. It is not unique to working copies.
- Working copies retain the actual bit of this they need: knowing where stuff should go on disk.

This doesn't run yet, but sure looks a lot cleaner!

Test Plan

Doesn't run yet, since Config isn't working yet.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Sep 18 2018, 7:53 PM

epriestley created this revision.

Harbormaster failed remote builds in B20855: Diff 47043!Sep 18 2018, 7:53 PM

One thing I'm dropping here that I don't explicitly plan to restore is all the logging. I may or may not put that back, depending on how things go and what feedback we see. I think I added it to make my job debugging some theoretical future issue easier, but that issue never materialized.

amckinley accepted this revision.Sep 20 2018, 12:00 AM

amckinley added inline comments.

src/workingcopy/ArcanistGitWorkingCopy.php
14	`pathExits` (Can't believe I spotted that with a drive-by review).
src/workingcopy/ArcanistMercurialWorkingCopy.php
14	`pathExits` again! Someone should butter me while I'm on this roll.
src/workingcopy/ArcanistSubversionWorkingCopy.php
42	👀