[Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php`
ClosedPublic
Actions

Authored by epriestley on Sep 18 2018, 5:21 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13098: Plans: Arcanist toolsets and extensions

Commits

rARCd8f660ec6f6a: [Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php`

Summary

Ref T13098. Currently, it lives in init-script.php. Move it to a separate file for similarity with support/PhabricatorStartup.php.

Two small changes here:

dirname(dirname(...)) adjustments for new path.
Remove memory_limit(-1), this is adjusted by the libphutil init script already.

Test Plan

Ran arc.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 18 2018, 5:21 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2018, 5:22 PM

Harbormaster failed remote builds in B20853: Diff 47040!

Removed some debugging code around $_ENV.

epriestley requested review of this revision.Sep 18 2018, 5:22 PM

amckinley accepted this revision.Sep 19 2018, 11:24 PM

This revision is now accepted and ready to land.Sep 19 2018, 11:24 PM

Closed by commit rARCd8f660ec6f6a: [Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php` (authored by epriestley). · Explain WhySep 21 2018, 11:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

init/

init-arcanist.php

588 lines

	support/	ArcanistRuntime.php/
	scripts/	init/


	init-arcanist.php

7 lines

Diff 47061

View Options

scripts/init/init-arcanist.php