Differential D19667

Fix a "withHasTransactions()" typo in AuditEditor
ClosedPublic
Actions

Authored by epriestley on Sep 12 2018, 7:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 8, 1:43 PM

	Unknown Object (File)
	Thu, Jan 2, 7:37 AM

	Unknown Object (File)
	Tue, Dec 31, 2:48 PM

	Unknown Object (File)
	Thu, Dec 12, 1:11 PM

	Unknown Object (File)
	Dec 11 2024, 6:41 AM

	Unknown Object (File)
	Dec 7 2024, 11:24 PM

	Unknown Object (File)
	Dec 4 2024, 10:51 PM

	Unknown Object (File)
	Dec 4 2024, 1:46 PM

View All Files

Subscribers

None

Tokens

"Pterodactyl" token, awarded by amckinley.

Details

Reviewers

amckinley

Commits

rP11ce459f67a4: (stable) Fix a "withHasTransactions()" typo in AuditEditor
rPcc3b6d57907b: Fix a "withHasTransactions()" typo in AuditEditor

Summary

See https://discourse.phabricator-community.org/t/typo-in-phabricatorauditeditor-php/1910. This is trivial and reproduces easily, I just missed it in testing.

Test Plan

Left a comment on a commit which I was the author of.
Before change: fatal with obvious typo.
After change: smooth sailing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 12 2018, 7:13 PM

Harbormaster completed remote builds in B20800: Diff 46990.Sep 12 2018, 7:14 PM

epriestley requested review of this revision.Sep 12 2018, 7:14 PM

amckinley accepted this revision.Sep 12 2018, 7:14 PM

This revision is now accepted and ready to land.Sep 12 2018, 7:14 PM

amckinley awarded a token.Sep 12 2018, 7:15 PM

Closed by commit rPcc3b6d57907b: Fix a "withHasTransactions()" typo in AuditEditor (authored by epriestley). · Explain WhySep 12 2018, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

2 lines

Diff 46991

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Fix a "withHasTransactions()" typo in AuditEditorClosedPublicActions