Expose "isDraft" and "holdAsDraft" revision properties over Conduit
ClosedPublic
Actions

Authored by epriestley on Sep 7 2018, 4:53 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13195: 2018 Week 36 Bonus Content

Commits

rP046c1b5b828d: Expose "isDraft" and "holdAsDraft" revision properties over Conduit

Summary

Ref T13195. See PHI861. The "+ Draft" flag is not currently exposed over the API, but seems stable enough to expose.

Also expose the "hold as draft" flag, normally arc diff --draft.

Today, you can get "+ Draft" with some other state by:

abandoning a draft revision ("Abandoned + Draft"); or
using arc diff --plan-changes with an older arc version ("Changes Planned + Draft").

Test Plan

Called differential.revision.search via Conduit and got sensible-looking results for revisions in various states.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 7 2018, 4:53 PM

Harbormaster completed remote builds in B20762: Diff 46955.Sep 7 2018, 4:55 PM

epriestley requested review of this revision.Sep 7 2018, 4:55 PM

amckinley accepted this revision.Sep 7 2018, 5:43 PM

This revision is now accepted and ready to land.Sep 7 2018, 5:43 PM

Closed by commit rP046c1b5b828d: Expose "isDraft" and "holdAsDraft" revision properties over Conduit (authored by epriestley). · Explain WhySep 7 2018, 6:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

16 lines

Diff 46958

View Options

src/applications/differential/storage/DifferentialRevision.php

Expose "isDraft" and "holdAsDraft" revision properties over ConduitClosedPublicActions