Page MenuHomePhabricator

Continue replacing Commit/Audit status checks with object-based checks
ClosedPublic

Authored by epriestley on Sep 7 2018, 4:05 PM.
Tags
None
Referenced Files
F15467932: D19647.id46953.diff
Thu, Apr 3, 6:25 PM
F15466178: D19647.id46963.diff
Thu, Apr 3, 2:32 AM
F15460423: D19647.id.diff
Mon, Mar 31, 10:59 PM
F15442337: D19647.id.diff
Wed, Mar 26, 10:52 PM
F15438189: D19647.diff
Tue, Mar 25, 11:42 PM
F15434198: D19647.id46963.diff
Tue, Mar 25, 2:36 AM
F15431564: D19647.diff
Mon, Mar 24, 1:09 PM
F15411801: D19647.id46953.diff
Wed, Mar 19, 9:51 AM
Subscribers
None

Details

Summary

Ref T13195. See PHI851. Continuing down the path toward replacing these legacy numeric constants with more modern string constants.

Test Plan
  • Raised concern, requested verification, verified.
  • Looked at commit hovercard with audit status.
  • Viewed header on a commit page.
  • (Didn't test the Doorkeeper stuff since it requires linking to Asana and seems unlikely to break.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable