Page MenuHomePhabricator

Continue replacing Commit/Audit status checks with object-based checks
ClosedPublic

Authored by epriestley on Sep 7 2018, 4:05 PM.
Tags
None
Referenced Files
F15547946: D19647.id.diff
Sat, Apr 26, 8:49 PM
F15541207: D19647.diff
Fri, Apr 25, 11:19 AM
F15511610: D19647.id46953.diff
Thu, Apr 17, 3:32 AM
F15467932: D19647.id46953.diff
Thu, Apr 3, 6:25 PM
F15466178: D19647.id46963.diff
Thu, Apr 3, 2:32 AM
F15460423: D19647.id.diff
Mon, Mar 31, 10:59 PM
F15442337: D19647.id.diff
Mar 26 2025, 10:52 PM
F15438189: D19647.diff
Mar 25 2025, 11:42 PM
Subscribers
None

Details

Summary

Ref T13195. See PHI851. Continuing down the path toward replacing these legacy numeric constants with more modern string constants.

Test Plan
  • Raised concern, requested verification, verified.
  • Looked at commit hovercard with audit status.
  • Viewed header on a commit page.
  • (Didn't test the Doorkeeper stuff since it requires linking to Asana and seems unlikely to break.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable