Page MenuHomePhabricator

Begin transitioning audits to modern (string) status constants, from legacy (integer) status constants
ClosedPublic

Authored by epriestley on Sep 5 2018, 5:32 PM.
Tags
None
Referenced Files
F19935336: D19642.id46936.diff
Sat, Apr 11, 9:46 PM
F19830139: D19642.id46936.diff
Mar 10 2026, 10:57 AM
F19825425: D19642.id.diff
Mar 8 2026, 11:26 AM
F19663315: D19642.diff
Feb 7 2026, 9:55 AM
F19572023: D19642.id.diff
Feb 1 2026, 3:16 AM
F19546528: D19642.id.diff
Jan 25 2026, 12:54 PM
F19517290: D19642.id46936.diff
Jan 15 2026, 9:34 AM
F19312966: D19642.id46936.diff
Dec 25 2025, 12:57 AM
Subscribers
None

Details

Summary

Ref T13195. See PHI851. Audits currently have older integer status constants. We've moved almost all object types away from this to string constants (which are better in basically every way, and particularly way better for exposing over the API).

Commits/audits are currently accessible over the API and expose these constants via a "statuses" constraint.

Prepare to move toward modern string constants by defining a new, more modern map of status details and defining the existing methods in terms of it.

Test Plan

Browsed audits checking for icons/names/open-ness, saw no changes. This change should have no user-visible effects, as it just reorganizes code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable