Page MenuHomePhabricator

Begin transitioning audits to modern (string) status constants, from legacy (integer) status constants
ClosedPublic

Authored by epriestley on Sep 5 2018, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 26 2025, 1:26 AM
Unknown Object (File)
Feb 22 2025, 2:34 AM
Unknown Object (File)
Feb 21 2025, 1:38 AM
Unknown Object (File)
Feb 19 2025, 3:14 PM
Unknown Object (File)
Feb 19 2025, 1:10 PM
Unknown Object (File)
Feb 14 2025, 11:02 AM
Unknown Object (File)
Feb 13 2025, 6:09 PM
Unknown Object (File)
Feb 9 2025, 6:27 AM
Subscribers
None

Details

Summary

Ref T13195. See PHI851. Audits currently have older integer status constants. We've moved almost all object types away from this to string constants (which are better in basically every way, and particularly way better for exposing over the API).

Commits/audits are currently accessible over the API and expose these constants via a "statuses" constraint.

Prepare to move toward modern string constants by defining a new, more modern map of status details and defining the existing methods in terms of it.

Test Plan

Browsed audits checking for icons/names/open-ness, saw no changes. This change should have no user-visible effects, as it just reorganizes code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable