Page MenuHomePhabricator
Differential D19641

In Conduit, let checkbox constraints self-document
ClosedPublic
Actions

Authored by epriestley on Sep 5 2018, 5:11 PM.
Tags
None
Referenced Files
F15434798: D19641.id.diff
Tue, Mar 25, 5:28 AM
F15433663: D19641.diff
Tue, Mar 25, 12:15 AM
F15400419: D19641.diff
Mon, Mar 17, 11:30 AM
F15396818: D19641.id46935.diff
Sun, Mar 16, 4:26 PM
F15379764: D19641.id46935.diff
Thu, Mar 13, 11:16 PM
F15364276: D19641.id46935.diff
Tue, Mar 11, 1:11 PM
F15339084: D19641.diff
Sun, Mar 9, 2:16 PM
Unknown Object (File)
Sat, Mar 1, 4:10 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13195: 2018 Week 36 Bonus Content
Commits
rP5a38b75f16ea: In Conduit, let checkbox constraints self-document
Summary

Ref T13195. Ref PHI851. Currently, checkbox constraints don't tell you what values are supported on the API page.

You can figure this out with "Inspect Element" or by viewing the source code, but just render a nice table instead.

Test Plan

constraints.png (668×788 px, 103 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 5 2018, 5:11 PM
Harbormaster completed remote builds in B20743: Diff 46935.Sep 5 2018, 5:12 PM
epriestley requested review of this revision.Sep 5 2018, 5:12 PM
amckinley accepted this revision.Sep 5 2018, 10:46 PM
This revision is now accepted and ready to land.Sep 5 2018, 10:46 PM
Closed by commit rP5a38b75f16ea: In Conduit, let checkbox constraints self-document (authored by epriestley). · Explain WhySep 6 2018, 3:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46947

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/data/ConduitConstantDescription.php

Loading...
View Options

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchCheckboxesField.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchField.php

Loading...
Phabricator · Built by Phacility