Page MenuHomePhabricator

Allow reviewers to mark their own inlines as "Done" before they submit them
ClosedPublic

Authored by epriestley on Sep 4 2018, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 8, 3:06 AM
Unknown Object (File)
Wed, Aug 3, 5:20 PM
Unknown Object (File)
Wed, Aug 3, 5:20 PM
Unknown Object (File)
Wed, Aug 3, 5:20 PM
Unknown Object (File)
Wed, Aug 3, 5:20 PM
Unknown Object (File)
Sat, Jul 23, 11:17 AM
Unknown Object (File)
Jul 11 2022, 4:51 AM
Unknown Object (File)
Jul 8 2022, 11:06 PM
Subscribers
None

Details

Summary

Ref T13195. Ref T8573. This allows reviewers to mark their own inline comments as "Done" before they submit them.

If you're leaving a non-actionable comment like "this is good", you can pre-check "Done" to give the author a hint that you don't expect any response.

Test Plan

On revisions and commits, added inlines as the author and a reviewer/auditor. Marked them done/not-done before submitting. As author, marked the not-done ones done after submitting. Checked preivews, toggled done/not done states.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/diffusion/controller/DiffusionInlineCommentController.php
86–87

I read the discussion in T8573, but this still feels weird.

This revision is now accepted and ready to land.Sep 5 2018, 10:32 PM
src/applications/diffusion/controller/DiffusionInlineCommentController.php
86–87

Hmm, which part feels weird? The motivation? The actual action?

Would it still feel weird if the UI said "Don't bother the author with a done checkbox for this comment [X]"?

This revision was automatically updated to reflect the committed changes.