Page MenuHomePhabricator
Differential D19573

When cancelling addition of an Almanac interface, return to the Device page
ClosedPublic
Actions

Authored by epriestley on Aug 13 2018, 4:32 PM.
Tags
None
Referenced Files
F18389098: D19573.id46794.diff
Fri, Aug 29, 5:25 AM
F18388896: D19573.id46798.diff
Fri, Aug 29, 5:11 AM
F18388894: D19573.id.diff
Fri, Aug 29, 5:11 AM
F18388798: D19573.id46794.diff
Fri, Aug 29, 5:05 AM
F18388632: D19573.id.diff
Fri, Aug 29, 4:38 AM
F18388609: D19573.id46798.diff
Fri, Aug 29, 4:36 AM
F18219320: D19573.id46794.diff
Tue, Aug 19, 11:22 AM
F18201471: D19573.id46798.diff
Mon, Aug 18, 7:44 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device
Commits
rPfb3ae72e367f: When cancelling addition of an Almanac interface, return to the Device page
Summary

Fixes T13184. In Almanac, interfaces are always added to devices. However, if you "Add New Interface" and then "Cancel", you go to the nonexistent /interface/ page.

Instead, return to the device page.

Test Plan

From a device page, clicked "Add Interface" and then "Cancel". Ended up back where I was.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
editor/
3 lines

Diff 46798

View Options

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

Loading...
Phabricator · Built by Phacility