Page MenuHomePhabricator

When building a config stack, stop SiteSource objects from poisoning the cache
ClosedPublic

Authored by epriestley on Jul 20 2018, 9:39 PM.
Tags
None
Referenced Files
F12803095: D19526.id46688.diff
Wed, Mar 27, 1:56 PM
Unknown Object (File)
Wed, Mar 6, 2:29 AM
Unknown Object (File)
Wed, Mar 6, 2:29 AM
Unknown Object (File)
Wed, Mar 6, 2:21 AM
Unknown Object (File)
Wed, Mar 6, 12:35 AM
Unknown Object (File)
Feb 20 2024, 7:16 PM
Unknown Object (File)
Jan 25 2024, 1:13 AM
Unknown Object (File)
Jan 24 2024, 9:05 PM
Subscribers
None

Details

Summary

Ref T13168. I'm not sure how this worked before, but I ran into this issue on my new laptop.

SiteSource accesses PhabrictatorEnv::getEnvConfig('phabricator.base-uri') when local, which may poison the cache and lock the value since we don't later discard the cache.

Specifically, when I access http://locala.phacility.com, I was getting an error like "You made a request for locala.phacility.com, but no configured site can serve this request.". This was because the base-uri was being incorrectly frozen as "local.phacility.com". The expectation is that it will match, so the standard PlatformSite will serve the request.

Test Plan
  • Before change: "no configured site" error.
  • After change: local instance works properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable