Page MenuHomePhabricator

When building a config stack, stop SiteSource objects from poisoning the cache
ClosedPublic

Authored by epriestley on Jul 20 2018, 9:39 PM.
Tags
None
Referenced Files
F18104735: D19526.id46695.diff
Sun, Aug 10, 1:45 PM
F18104734: D19526.id46688.diff
Sun, Aug 10, 1:45 PM
F18104733: D19526.id.diff
Sun, Aug 10, 1:45 PM
F18100558: D19526.diff
Sat, Aug 9, 11:56 AM
F18083126: D19526.id46695.diff
Tue, Aug 5, 9:01 AM
F18050911: D19526.diff
Sun, Aug 3, 9:30 PM
F17795518: D19526.id46695.diff
Jul 25 2025, 12:20 AM
F17770899: D19526.id46695.diff
Jul 23 2025, 10:24 AM
Subscribers
None

Details

Summary

Ref T13168. I'm not sure how this worked before, but I ran into this issue on my new laptop.

SiteSource accesses PhabrictatorEnv::getEnvConfig('phabricator.base-uri') when local, which may poison the cache and lock the value since we don't later discard the cache.

Specifically, when I access http://locala.phacility.com, I was getting an error like "You made a request for locala.phacility.com, but no configured site can serve this request.". This was because the base-uri was being incorrectly frozen as "local.phacility.com". The expectation is that it will match, so the standard PlatformSite will serve the request.

Test Plan
  • Before change: "no configured site" error.
  • After change: local instance works properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable