Paths

Table of Contentst

Differential D19495

Correctly attach users to identities
ClosedPublic
Actions

Authored by amckinley on Jun 18 2018, 10:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 31, 11:44 PM

	Unknown Object (File)
	Sun, Mar 31, 11:44 PM

	Unknown Object (File)
	Sun, Mar 31, 11:44 PM

	Unknown Object (File)
	Sun, Mar 31, 11:44 PM

	Unknown Object (File)
	Mar 21 2024, 6:31 PM

	Unknown Object (File)
	Jan 26 2024, 8:49 AM

	Unknown Object (File)
	Jan 23 2024, 6:07 PM

	Unknown Object (File)
	Jan 11 2024, 12:11 PM

View All 71 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP787c59744be8: Correctly attach users to identities

Summary

This never worked.

Test Plan

Ran bin/repository rebuild-identities and viewed identity objects with currentEffectiveUserIDs and no longer got errors about attempting to attach null objects instead of PhabricatorUser objects.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Jun 18 2018, 10:12 PM

Harbormaster completed remote builds in B20426: Diff 46620.Jun 18 2018, 10:13 PM

amckinley requested review of this revision.Jun 18 2018, 10:13 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 18 2018, 10:13 PM

epriestley accepted this revision.Jun 18 2018, 10:18 PM

This revision is now accepted and ready to land.Jun 18 2018, 10:18 PM

Closed by commit rP787c59744be8: Correctly attach users to identities (authored by amckinley). · Explain WhyJun 18 2018, 10:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

query/

PhabricatorRepositoryIdentityQuery.php

21 lines

Diff 46621

View Options

src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php

Correctly attach users to identitiesClosedPublicActions