Ref T13152. The pager does a bit of magic here and doesn't populate nextPageID when it knows it got an exact final page. The logic misfired in this case and sent us back to the start.
Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13152: Storage on `secure` was filled by binlogs from looping (?) rebuild-identities script
- Commits
- rP340150a60600: (stable) Fix loop in QueryIterator when row count is an exact multiple of page…
rP13dd3014a758: Fix loop in QueryIterator when row count is an exact multiple of page size
- Set page size to 1 to guarantee rows were an exact multiple of page size.
- Ran rebuild-identities (I no-op'd the actual logic to make it faster).
- Before: looped forever.
- After: clean exit after processing everything.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable