Prevent double mysqli close() after query timeout
ClosedPublic
Actions

Authored by epriestley on Jun 5 2018, 1:03 PM.

Details

Reviewers

amckinley

Maniphest Tasks

Unknown Object (Maniphest Task)

Commits

rPHU4d341cfcc51c: Prevent double mysqli close() after query timeout

Summary

Ref T13149. I ran into this while double checking query timeout behavior for T13149.

After a query times out, we close the connection. We may then try to close the connection again in the destructor. Modern mysqli, at least, doesn't like this very much.

Instead, keep track of whether the connection needs to be closed or not.

Test Plan

Ran a SELECT SLEEP(60) with a 3 second query timeout.
Before: query timeout exception, then second exception on double-close().
After: query timeout exception, then no second exception.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 5 2018, 1:03 PM

Harbormaster completed remote builds in B20367: Diff 46559.Jun 5 2018, 1:04 PM

epriestley requested review of this revision.Jun 5 2018, 1:04 PM

epriestley mentioned this in Unknown Object (Maniphest Task).Jun 5 2018, 1:05 PM

amckinley accepted this revision.Jun 5 2018, 10:03 PM

This revision is now accepted and ready to land.Jun 5 2018, 10:03 PM

Closed by commit rPHU4d341cfcc51c: Prevent double mysqli close() after query timeout (authored by epriestley). · Explain WhyJun 7 2018, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

storage/

connection/

mysql/

AphrontMySQLiDatabaseConnection.php

9 lines

Diff 46580

View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Prevent double mysqli close() after query timeoutClosedPublicActions