Page MenuHomePhabricator

Rename a distro package name in a message
AbandonedPublic

Authored by epriestley on May 9 2018, 8:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 22 2024, 2:07 AM
Unknown Object (File)
Oct 21 2024, 9:20 AM
Unknown Object (File)
Sep 17 2024, 9:35 PM
Unknown Object (File)
Sep 15 2024, 6:02 PM
Unknown Object (File)
Sep 9 2024, 8:17 AM
Unknown Object (File)
Sep 6 2024, 6:12 AM
Unknown Object (File)
Sep 6 2024, 3:22 AM
Unknown Object (File)
Sep 4 2024, 10:28 AM
Subscribers

Details

Summary

Both Debian & Ubuntu renamed php5- to php-. Updating the message accordingly

Test Plan

this is just a string being displayed.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sylvestre retitled this revision from Rename a package name in a message to Rename a distro package name in a message.May 9 2018, 8:46 AM
epriestley abandoned this revision.
epriestley edited reviewers, added: sylvestre; removed: epriestley.

This change is not obviously correct and not sufficiently supported by your summary and test plan to make it clear that it is correct.

If you'd like this changed in the upstream, please start with a thread on the Discourse forum.

I don't care enough about that but thanks :)

Okay, please don't just throw things against the upstream in the future and hope they stick. We will never accept changes we can't maintain, and I don't understand this well enough to maintain it. You're just wasting your time and our time when you do this. The documentation tries to make it very clear that we don't want patches without explanations, e.g.:

Before sending code, you should file a task describing what you'd like to write.

For example, on this server, the correct package name is php5-curl:

$ sudo apt-get install php5-curl
...
php5-curl is already the newest version.

...and there is no php-curl:

$ sudo apt-get install php-curl
...
E: Unable to locate package php-curl

So this change is wrong and actively harmful for all hosts we have in production, and likely for many hosts maintained by active installs. A different change (for example: detecting OS version and emitting the right alternative; or suggesting both alternatives with guidance like "versions before X") is likely much better, but you haven't given me enough information to understand the problem or evaluate approaches.

I'm going to disable your account on this install because of the low quality of this interaction. You're welcome to continue interacting with the community on the Discourse forum.