Page MenuHomePhabricator

Fix an issue where entering the same Owners path for two repositories would incorrectly de-dupe the path
ClosedPublic

Authored by epriestley on May 1 2018, 1:58 PM.
Tags
None
Referenced Files
F15440975: D19420.id46456.diff
Wed, Mar 26, 3:49 PM
F15382467: D19420.diff
Fri, Mar 14, 12:31 PM
F15380351: D19420.id46456.diff
Fri, Mar 14, 2:39 AM
Unknown Object (File)
Feb 28 2025, 12:10 AM
Unknown Object (File)
Feb 26 2025, 1:19 AM
Unknown Object (File)
Feb 25 2025, 3:39 PM
Unknown Object (File)
Feb 20 2025, 9:54 PM
Unknown Object (File)
Feb 20 2025, 9:54 PM
Subscribers
None

Details

Summary

Ref T13130. See https://discourse.phabricator-community.org/t/unable-to-create-owners-package-with-same-path-in-multiple-repositories/1400/1.

When you edit paths in Owners, we deduplicate similar paths, like /x/y and /x/y/. However, this logic currently only examines the paths, and incorrectly deduplicates the same path in different repositories.

Instead, consider the repository before deduplicating.

Test Plan
  • Edited an Owners package and added the path "/" in two different repositories.
  • Before: only one surived the edit.
  • After: both survived.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable