Page MenuHomePhabricator

Fix an issue where entering the same Owners path for two repositories would incorrectly de-dupe the path
ClosedPublic

Authored by epriestley on May 1 2018, 1:58 PM.
Tags
None
Referenced Files
F18848065: D19420.id.diff
Thu, Oct 30, 3:14 AM
F18846058: D19420.diff
Wed, Oct 29, 4:20 PM
F18803838: D19420.id46456.diff
Sat, Oct 18, 4:15 AM
F18798870: D19420.diff
Fri, Oct 17, 9:31 AM
F18706157: D19420.diff
Sep 28 2025, 3:36 PM
F18704622: D19420.id46456.diff
Sep 28 2025, 8:18 AM
F18703221: D19420.id.diff
Sep 28 2025, 3:18 AM
F18700974: D19420.diff
Sep 27 2025, 4:38 PM
Subscribers
None

Details

Summary

Ref T13130. See https://discourse.phabricator-community.org/t/unable-to-create-owners-package-with-same-path-in-multiple-repositories/1400/1.

When you edit paths in Owners, we deduplicate similar paths, like /x/y and /x/y/. However, this logic currently only examines the paths, and incorrectly deduplicates the same path in different repositories.

Instead, consider the repository before deduplicating.

Test Plan
  • Edited an Owners package and added the path "/" in two different repositories.
  • Before: only one surived the edit.
  • After: both survived.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable