Page MenuHomePhabricator

Fix an issue where entering the same Owners path for two repositories would incorrectly de-dupe the path
ClosedPublic

Authored by epriestley on May 1 2018, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 2:18 PM
Unknown Object (File)
Wed, Mar 27, 7:52 AM
Unknown Object (File)
Wed, Mar 27, 7:52 AM
Unknown Object (File)
Wed, Mar 27, 7:52 AM
Unknown Object (File)
Wed, Mar 27, 7:52 AM
Unknown Object (File)
Sat, Mar 16, 7:04 AM
Unknown Object (File)
Feb 23 2024, 4:10 PM
Unknown Object (File)
Feb 21 2024, 7:52 AM
Subscribers
None

Details

Summary

Ref T13130. See https://discourse.phabricator-community.org/t/unable-to-create-owners-package-with-same-path-in-multiple-repositories/1400/1.

When you edit paths in Owners, we deduplicate similar paths, like /x/y and /x/y/. However, this logic currently only examines the paths, and incorrectly deduplicates the same path in different repositories.

Instead, consider the repository before deduplicating.

Test Plan
  • Edited an Owners package and added the path "/" in two different repositories.
  • Before: only one surived the edit.
  • After: both survived.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable